Skip to content

ci-workflow-gen: turn string to array to reduce conflicts #7582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlomi-noach merged 3 commits into from
Mar 7, 2021
Merged

ci-workflow-gen: turn string to array to reduce conflicts #7582

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2003424
ci-workflow-gen: turn string to array to reduce conflicts
shlomi-noach Mar 2, 2021
e0e3fbd
merge master, resolve conflicts
shlomi-noach Mar 3, 2021
bb4ce09
merge master, resolve conflict
shlomi-noach Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 47 additions & 5 deletions test/ci_workflow_gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,43 @@ const (
unitTestDatabases = "percona56, mysql57, mysql80, mariadb101, mariadb102, mariadb103"

clusterTestTemplate = "templates/cluster_endtoend_test.tpl"
clusterList = "11,12,13,14,15,16,17,18,19,20,21,22,23,24,26,27,vreplication_basic,vreplication_multicell,vreplication_cellalias,vreplication_v2,onlineddl_ghost,onlineddl_vrepl,onlineddl_vrepl_stress,vreplication_migrate,onlineddl_revert"
)

var (
clusterList = []string{
"11",
"12",
"13",
"14",
"15",
"16",
"17",
"18",
"19",
"20",
"21",
"22",
"23",
"24",
"26",
"27",
"vreplication_basic",
"vreplication_multicell",
"vreplication_cellalias",
"vreplication_v2",
"onlineddl_ghost",
"onlineddl_vrepl",
"onlineddl_vrepl_stress",
"vreplication_migrate",
"onlineddl_revert",
}
// TODO: currently some percona tools including xtrabackup are installed on all clusters, we can possibly optimize
// this by only installing them in the required clusters
clustersRequiringXtraBackup = clusterList
clustersRequiringMakeTools = "18,24"
clustersRequiringMakeTools = []string{
"18",
"24",
}
)

type unitTest struct {
Expand Down Expand Up @@ -72,6 +104,16 @@ func main() {
generateClusterWorkflows()
}

func canonnizeList(list []string) []string {
var output []string
for _, item := range list {
item = strings.TrimSpace(item)
if item != "" {
output = append(output, item)
}
}
return output
}
func parseList(csvList string) []string {
var list []string
for _, item := range strings.Split(csvList, ",") {
Expand All @@ -81,20 +123,20 @@ func parseList(csvList string) []string {
}

func generateClusterWorkflows() {
clusters := parseList(clusterList)
clusters := canonnizeList(clusterList)
for _, cluster := range clusters {
test := &clusterTest{
Name: fmt.Sprintf("Cluster (%s)", cluster),
Shard: cluster,
}
makeToolClusters := parseList(clustersRequiringMakeTools)
makeToolClusters := canonnizeList(clustersRequiringMakeTools)
for _, makeToolCluster := range makeToolClusters {
if makeToolCluster == cluster {
test.MakeTools = true
break
}
}
xtraBackupClusters := parseList(clustersRequiringXtraBackup)
xtraBackupClusters := canonnizeList(clustersRequiringXtraBackup)
for _, xtraBackupCluster := range xtraBackupClusters {
if xtraBackupCluster == cluster {
test.InstallXtraBackup = true
Expand Down