Add option to log queries only when rows returned/affected >= X#5938
Closed
aquarapid wants to merge 2 commits intovitessio:masterfrom
Closed
Add option to log queries only when rows returned/affected >= X#5938aquarapid wants to merge 2 commits intovitessio:masterfrom
aquarapid wants to merge 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Contributor
|
The idea behind the querylog was that you could do the filtering on the client side on various criteria using a tool like awk; The fields are tab separated. Is there a use case where this would not work? |
Contributor
Author
|
Where you just have too many queries to log; as multiple Vitess users have shared...? |
Collaborator
|
@sougou ping. Is the reasoning behind this PR acceptable? |
sougou
approved these changes
Oct 31, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Can you do a rebase (or anything else to retrigger the hung tests)? Once it passes, we can merge.
Contributor
Author
|
Things have changed underneath a bit, I'm just going to redo this PR. |
aquarapid
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 17, 2021
certain number of rows. Redo of PR vitessio#5938, minimizing type changes this time. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.