Skip to content

Fixes for vagrant setup#4782

Merged
rafael merged 1 commit intovitessio:masterfrom
tinyspeck:fixes-for-vm
Apr 2, 2019
Merged

Fixes for vagrant setup#4782
rafael merged 1 commit intovitessio:masterfrom
tinyspeck:fixes-for-vm

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Apr 2, 2019

Desc

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner April 2, 2019 21:58
Copy link
Copy Markdown
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafael rafael merged commit 3818c0b into vitessio:master Apr 2, 2019
@rafael rafael deleted the fixes-for-vm branch April 2, 2019 22:41
cd "$VITESS_WORKSPACE"

# open-jdk version that we are using in the VM needs this flag, otherwise we will fail to build ZK
export JAVA_TOOL_OPTIONS="-Dhttps.protocols=TLSv1.2"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in vagrant we install openjdk-7-jdk while in Docker we use openjdk-8-jdk.

This is another example for #4780

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This is a limitation of the ubuntu version we are using in the Vagrant setup. We need to do some upgrades. openjdk-8 is not available. I think we should do that as part of a different PR.

@guidoiaquinti
Copy link
Copy Markdown
Member

guidoiaquinti commented Apr 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants