Change common unhandled packet error message to clarify origin#4547
Change common unhandled packet error message to clarify origin#4547sjmudd wants to merge 1 commit intovitessio:masterfrom
Conversation
|
Oddly enough this came I think from a 8.0.13 mysql client. Which is odd as https://dev.mysql.com/doc/dev/mysql-server/8.0.11/page_protocol_com_field_list.html indicates this is |
|
Was this a vtgate version older than December 22nd? #4486 fixed a bug in com_set_option which wasn't mentioned in the PR description. There was a missing call to recycleReadPacket |
|
I think the code I'm using is newer. The code I'm running is 6cf46db so not sure. |
|
I messed up something trying to fix the sign-off so have done a new PR. Bit stupid, sorry. so closing this one. |
conn.gohas 3 identical error messages for different situations so it's harder to identify where an error has been triggered. This change simply identifies the part of the code affected for easier analysis.I basically saw this and without protocol knowledge it's not clear which part of the code is triggering the error: