Skip to content

Change common unhandled packet error message to clarify origin #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjmudd wants to merge 1 commit into from
Closed

Change common unhandled packet error message to clarify origin #4547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/mysql/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ func (c *Conn) handleNextCommand(handler Handler) error {
case 1:
c.Capabilities &^= CapabilityClientMultiStatements
default:
log.Errorf("Got unhandled packet from client %v, returning error: %v", c.ConnectionID, data)
log.Errorf("Got unhandled packet (ComSetOption default) from client %v, returning error: %v", c.ConnectionID, data)
if err := c.writeErrorPacket(ERUnknownComError, SSUnknownComError, "error handling packet: %v", data); err != nil {
log.Errorf("Error writing error packet to client: %v", err)
return err
Expand All @@ -791,14 +791,14 @@ func (c *Conn) handleNextCommand(handler Handler) error {
return err
}
} else {
log.Errorf("Got unhandled packet from client %v, returning error: %v", c.ConnectionID, data)
log.Errorf("Got unhandled packet (ComSetOption else) from client %v, returning error: %v", c.ConnectionID, data)
if err := c.writeErrorPacket(ERUnknownComError, SSUnknownComError, "error handling packet: %v", data); err != nil {
log.Errorf("Error writing error packet to client: %v", err)
return err
}
}
default:
log.Errorf("Got unhandled packet from %s, returning error: %v", c, data)
log.Errorf("Got unhandled packet (default) from %s, returning error: %v", c, data)
c.recycleReadPacket()
if err := c.writeErrorPacket(ERUnknownComError, SSUnknownComError, "command handling not implemented yet: %v", data[0]); err != nil {
log.Errorf("Error writing error packet to %s: %s", c, err)
Expand Down