Skip to content

tlstest_test: Go 1.12 / TLS 1.3 fix #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alainjobart merged 1 commit into from
Jan 14, 2019
Merged

tlstest_test: Go 1.12 / TLS 1.3 fix #4520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions go/vt/tlstest/tlstest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,21 @@ func TestClientServer(t *testing.T) {
serverConn.Close()
}()

if _, err = tls.Dial("tcp", addr, badClientConfig); err == nil {
t.Fatalf("Dial was expected to fail")
// When using TLS 1.2, the Dial will fail.
// With TLS 1.3, the Dial will succeed and the first Read will fail.
clientConn, err := tls.Dial("tcp", addr, badClientConfig)
if err != nil {
if !strings.Contains(err.Error(), "bad certificate") {
t.Errorf("Wrong error returned: %v", err)
}
return
}
data := make([]byte, 1)
_, err = clientConn.Read(data)
if err == nil {
t.Fatalf("Dial or first Read was expected to fail")
}
if !strings.Contains(err.Error(), "bad certificate") {
t.Errorf("Wrong error returned: %v", err)
}
t.Logf("Dial returned: %v", err)
}