grpc: rework the window size settings to apply on the server#4030
Closed
demmer wants to merge 1 commit intovitessio:masterfrom
Closed
grpc: rework the window size settings to apply on the server#4030demmer wants to merge 1 commit intovitessio:masterfrom
demmer wants to merge 1 commit intovitessio:masterfrom
Conversation
In addition to setting the initial conn window / initial window size settings on the grpc client side, also set the corresponding options for the server side. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Member
|
LGTM +1 Is there any world where someone might want different settings for server and client? I was taking that approach before I left, but I'm not sure if it really matters. |
rafael
approved these changes
Jun 16, 2018
Member
Author
|
#4037 is the better approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to setting the initial conn window / initial window size settings on the grpc client side, also set the corresponding options for the server side.
I noticed when using wireshark to inspect the traffic going back and forth, that the GRPC settings need to be applied on both the client and server side so that the flow control is applied to accepted connections as well as those initiated outbound.