Add grpc window size server config#4037
Merged
demmer merged 2 commits intovitessio:masterfrom Jun 20, 2018
Merged
Conversation
added 2 commits
June 18, 2018 11:44
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
rafael
force-pushed
the
add-grpc-window-size-server-config
branch
from
48bc161 to
954179d
Compare
demmer
approved these changes
Jun 20, 2018
Member
|
Having separate flags is better than my approach in #4030 It's a bit more tedious to configure, but there are rational reasons why someone would want different inbound vs outbound settings for this, so adding two more flags on top of the hundred others is still somewhat reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds grpc window size settings for server side.
Per discussion in real life, given that gRPC treats client and server as different settings, we will like to keep the same behavior here. We will favor this PR instead of #4030