Fix TestTrackerNoLock flaky test by increasing time to mark failure#17886
Merged
deepthi merged 1 commit intovitessio:mainfrom Mar 3, 2025
Merged
Fix TestTrackerNoLock flaky test by increasing time to mark failure#17886deepthi merged 1 commit intovitessio:mainfrom
deepthi merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
frouioui
approved these changes
Mar 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17886 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 1595 1595
Lines 259640 259640
=======================================
+ Hits 175292 175308 +16
+ Misses 84348 84332 -16 ☔ View full report in Codecov by Sentry. |
deepthi
approved these changes
Mar 3, 2025
| select { | ||
| case ch <- th: | ||
| case <-time.After(5 * time.Millisecond): | ||
| case <-time.After(10 * time.Millisecond): |
Collaborator
There was a problem hiding this comment.
No guarantee that this will not be flaky even then. We should look at the new synctest package in 1.24 to see if that can be used to reduce flakiness in tests that depend on time. We can approve and merge for now.
Member
Author
There was a problem hiding this comment.
I can look into for main. This needs to be ported to v20 and v21.
harshit-gangal
added a commit
that referenced
this pull request
Mar 4, 2025
…17886) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
added a commit
that referenced
this pull request
Mar 4, 2025
…17886) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Test was introduced in PR #17873.
This needs to be backported till v20 to have flaky fixes in all branches.
Related Issue(s)
Checklist
Deployment Notes