Fix: Separate Lock for Keyspace to Update Controller Mapping in Schema Tracking

[harshit-gangal]

Description

Problem

Previously, schema tracking update calls to VTTablet via GetSchema RPC and access to the keyspace-to-update-controller mapping (tracked map) were using the same lock. These operations are unrelated, but GetSchema RPC calls can be slow due to network-related reasons.

As a result, fetching the update controller from the map was blocked, leading to:

• Slow processing of health updates
• Channel overflow, causing dropped health check updates

Solution

Introduced a separate mutex for managing access to the tracked map, ensuring that schema tracking operations are not blocked by RPC calls. This prevents delays in processing health updates and improves overall stability.

Backport Reason: Health check misses can lead to missing schema changes.

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (b05df12) to head (816df9e).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtgate/schema/tracker.go	86.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17873      +/-   ##
==========================================
+ Coverage   67.45%   67.47%   +0.01%     
==========================================
  Files        1594     1594              
  Lines      259064   259075      +11     
==========================================
+ Hits       174760   174813      +53     
+ Misses      84304    84262      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GuptaManan100]

While this works, should we get rid of the locking altogether in the codepath that is reading data from vttablets?

[harshit-gangal]

While this works, should we get rid of the locking altogether in the codepath that is reading data from vttablets?

The Table Map is shared between keyspaces and we run go-routine per keyspace. The lock is required will updating those maps.

[systay]

I'm thinking we should make it easy to see in the struct declaration which fields are protected by which mutex. trackedMu is kind of easy, but what the mu mutex is protecting is hard to see here.