Skip to content

Fix TestTrackerNoLock flaky test by increasing time to mark failure #17886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
Mar 3, 2025
Merged

Fix TestTrackerNoLock flaky test by increasing time to mark failure #17886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/vtgate/schema/tracker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func TestTrackerNoLock(t *testing.T) {
for i := 0; i < 500000; i++ {
select {
case ch <- th:
case <-time.After(5 * time.Millisecond):
case <-time.After(10 * time.Millisecond):
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No guarantee that this will not be flaky even then. We should look at the new synctest package in 1.24 to see if that can be used to reduce flakiness in tests that depend on time. We can approve and merge for now.

https://go.dev/blog/synctest

Copy link
Copy Markdown
Member Author

@harshit-gangal harshit-gangal Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look into for main. This needs to be ported to v20 and v21.

t.Fatalf("failed to send health check to tracker")
}
}
Expand Down
Loading