Skip to content

[release-21.0] [VTAdmin] Insert into schema cache if exists already and not expired (#17908)#17924

Merged
notfelineit merged 1 commit intorelease-21.0from
backport-17908-to-release-21.0
Mar 6, 2025
Merged

[release-21.0] [VTAdmin] Insert into schema cache if exists already and not expired (#17908)#17924
notfelineit merged 1 commit intorelease-21.0from
backport-17908-to-release-21.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Mar 6, 2025

Description

This is a backport of #17908

@vitess-bot vitess-bot bot requested a review from notfelineit as a code owner March 6, 2025 16:05
@vitess-bot vitess-bot bot added the Backport This is a backport label Mar 6, 2025
@vitess-bot vitess-bot bot requested a review from rohit-nayak-ps as a code owner March 6, 2025 16:05
@vitess-bot vitess-bot bot added the Component: VTAdmin VTadmin interface label Mar 6, 2025
@vitess-bot vitess-bot bot requested a review from deepthi as a code owner March 6, 2025 16:05
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Mar 6, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.4 milestone Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (913c838) to head (7b3c90d).
Report is 5 commits behind head on release-21.0.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-21.0   #17924   +/-   ##
=============================================
  Coverage         67.52%   67.53%           
=============================================
  Files              1572     1572           
  Lines            252012   252033   +21     
=============================================
+ Hits             170173   170210   +37     
+ Misses            81839    81823   -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notfelineit notfelineit merged commit 8c26746 into release-21.0 Mar 6, 2025
201 checks passed
@notfelineit notfelineit deleted the backport-17908-to-release-21.0 branch March 6, 2025 19:34
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 8, 2025
@timvaillancourt @vitess-bot
@rohit-nayak-ps @vitess-bot @GuptaManan100 @frouioui @systay @mattlord @dbussink @harshit-gangal @vmg @shlomi-noach @rvrangel @arthurschreiber @maxenglander
slack-21.0: merge upstream v21.0.4 release (#636)
406edf8 
* [release-21.0] Bump to `v21.0.4-SNAPSHOT` after the `v21.0.3` release (vitessio#17766)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>

* [release-21.0] smartconnpool: Better handling for idle expiration (vitessio#17757) (vitessio#17781)

Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Fail assignment expressions with the correct message (vitessio#17752) (vitessio#17776)

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

* [release-21.0] Multi-tenant workflow SwitchWrites: Don't add denied tables on cancelMigration() (vitessio#17782) (vitessio#17797)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] VReplication Atomic Copy Workflows: fix bugs around concurrent inserts (vitessio#17772) (vitessio#17793)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Upgrade the Golang version to `go1.23.6` (vitessio#17699)

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* [release-21.0] Fix a potential connection pool leak. (vitessio#17807) (vitessio#17814)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* backport: support subqueries inside subqueries when merging (Release 21.0) (vitessio#17811)

Signed-off-by: Andres Taylor <andres@planetscale.com>

* [release-21.0] Fix vtcombo parsing flags incorrectly (vitessio#17743) (vitessio#17820)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

* [release-21.0] pool: reopen connection closed by idle timeout (vitessio#17818) (vitessio#17829)

* [release-21.0] Implement temporal comparisons (vitessio#17826) (vitessio#17854)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] evalengine: normalize types during compilation (vitessio#17887) (vitessio#17896)

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Vicent Marti <vmg@strn.cat>

* [release-21.0] Fix: Separate Lock for Keyspace to Update Controller Mapping in Schema Tracking (vitessio#17873) (vitessio#17885)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* [release-21.0] Upgrade the Golang version to `go1.23.7` (vitessio#17901)

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* [release-21.0] fix: race on storing schema engine last changed time (vitessio#17914) (vitessio#17917)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* [release-21.0] [VTAdmin] Insert into schema cache if exists already and not expired (vitessio#17908) (vitessio#17924)

Signed-off-by: Frances Thai <notfelineit@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Bump golang.org/x/net from 0.34.0 to 0.36.0 (vitessio#17958) (vitessio#17960)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] fix flaky test on mysqlshell backup engine  (vitessio#17981)

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Renan Rangel <rvrangel@users.noreply.github.com>

* [release-21.0] DML test fix for duplicate column value  (vitessio#17980)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* [release-21.0] Fix DISTINCT on ENUM/SET columns by making enums/set hashable (vitessio#17936) (vitessio#17991)

Signed-off-by: Gene Parmesan Thomas <201852096+gopoto@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Fix tablet selection in `vtctld BackupShard` (vitessio#18002) (vitessio#18025)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Set proper join vars type for the RHS field query in OLAP (vitessio#18028) (vitessio#18038)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* [release-21.0] Use release branches for upgrade downgrade tests (vitessio#18029) (vitessio#18035)

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Test: Increase query timeout to fix flaky test 'TestQueryTimeoutWithShardTargeting' (vitessio#18016) (vitessio#18040)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] fix: App and Dba Pool metrics (vitessio#18048) (vitessio#18084)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Upgrade the Golang version to `go1.23.8` (vitessio#18092)

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* [release-21.0] bugfix: allow window functions when possible to push down (vitessio#18103) (vitessio#18105)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* [release-21.0] VDiff: Fix logic for reconciling extra rows (vitessio#17950) (vitessio#18072)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] VStream API: Reset stopPos in catchup (vitessio#18119) (vitessio#18122)

Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Fix `Reshard Cancel` behavior (vitessio#18020) (vitessio#18080)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

* Fix backup shard copy paste error (vitessio#18100)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* [release-21.0] go/vt/vtgate: take routing rules into account for traffic mirroring (vitessio#17953) (vitessio#17994)

Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Max Englander <max@planetscale.com>

* [release-21.0] Bugfix: Missing data when running vtgate outer joins (vitessio#18036) (vitessio#18044)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-21.0] Filter out tablets with unknown replication lag when electing a new primary (vitessio#18004) (vitessio#18075)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

* [release-21.0] Fix: Ensure Consistent Lookup Vindex Handles Duplicate Rows in Single Query (vitessio#17974) (vitessio#18078)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* [release-21.0] Code Freeze for `v21.0.4` (vitessio#18135)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* [release-21.0] Release of `v21.0.4` (vitessio#18136)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test fix

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Revert "test fix"

This reverts commit 55aec5c.

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Frances Thai <notfelineit@gmail.com>
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Signed-off-by: Gene Parmesan Thomas <201852096+gopoto@users.noreply.github.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: vitess-bot <139342327+vitess-bot@users.noreply.github.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Andrés Taylor <andres@planetscale.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Renan Rangel <rvrangel@users.noreply.github.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: Max Englander <max@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi

+2 more reviewers

@notfelineit notfelineit notfelineit approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport This is a backport Component: VTAdmin VTadmin interface go Type: Bug

Projects

None yet

Milestone

v21.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@notfelineit @frouioui @GuptaManan100