Fix CheckMySQL by setting the correct wanted state#11895
Merged
GuptaManan100 merged 1 commit intovitessio:mainfrom Dec 7, 2022
Merged
Fix CheckMySQL by setting the correct wanted state#11895GuptaManan100 merged 1 commit intovitessio:mainfrom
GuptaManan100 merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
harshit-gangal,
rohit-nayak-ps,
shlomi-noach and
systay
as code owners
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
harshit-gangal
approved these changes
Dec 7, 2022
frouioui
approved these changes
Dec 7, 2022
Contributor
|
I was unable to backport this Pull Request to the following branches: |
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Dec 7, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Dec 7, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Dec 7, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
harshit-gangal
pushed a commit
that referenced
this pull request
Dec 7, 2022
harshit-gangal
pushed a commit
that referenced
this pull request
Dec 7, 2022
GuptaManan100
added a commit
that referenced
this pull request
Dec 8, 2022
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
Feb 19, 2023
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug uncovered in #11885 (comment).
The main issue is that when we call
CheckMySQLwe do not set the correct wanted state. This leads to new queries not being blocked while we are waiting for the requests waitgroup to be empty.After looking at the history of how the code evolved in #11885, the intent of the code and the bug was clear.
This PR fixes the bug and augments an existing test to verify that we indeed do not allow new queries to come in when checkMySQL has started running.
Related Issue(s)
Checklist
Deployment Notes