Backport v13+ CheckMySQL fixes in tabletserver state manager#50
Merged
timvaillancourt merged 2 commits intoslack-vitess-r12.0.5from Feb 22, 2023
Merged
Conversation
* feat: add gauge for checkMySQL running Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix data race by converting bool to atomic bool Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
timvaillancourt
requested review from
brirams,
darenseagrave,
pbibra,
rvrangel and
tanjinx
pbibra
reviewed
Feb 22, 2023
pbibra
reviewed
Feb 22, 2023
brirams
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the following 2 x PRs (from v13+) that should cause tablets with crashed
mysqlds to becomeNOT_SERVINGPRs:
Checklist
Deployment Notes