Fixes the SwitchTraffic bug that wasn't respecting --dry_run for readonly and replica tablets during a resharding event#91
Conversation
Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
austenLacy
requested review from
WilliamLu99,
annzenkina,
brendar,
hkdsun and
toria-shopify
austenLacy
changed the title
SwitchTraffic bug that wasn't respect --dry_run for readonly and replica tablets during a resharding event
brendar
left a comment
brendar
left a comment
There was a problem hiding this comment.
Looks good to me. Submit it upstream?
austenLacy
changed the title
SwitchTraffic bug that wasn't respect --dry_run for readonly and replica tablets during a resharding eventSwitchTraffic bug that wasn't respecting --dry_run for readonly and replica tablets during a resharding event
Yep, might as well. Will be curious to see if they'll accept it or reopen the original PR. Either way should be fine for us. |
hkdsun
left a comment
hkdsun
left a comment
There was a problem hiding this comment.
Nice catch 👍 I'm sure it will get merged
Missing context? 🤔 |
|
@hkdsun the linked issue has a PR that was closed (not sure why) with the same fix - vitessio#6497 |
|
Upstream PR was merged - vitessio#12992 It had some e2e tests that have some conflicts with the |
|
I'm fine with merging as is |
austenLacy
deleted the
austenlacy/vitess-project-431/respect-dry-run-flag-on-switchtraffic
branch
Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com> (cherry picked from commit 46f1def)
4 participants
ref: https://github.com/Shopify/vitess-project/issues/431
Fixes the
SwitchTrafficbug that wasn't respecting--dry_runfor readonly and replica tablets during a resharding event. More details specifically in this comment.