Skip to content

Fix files changes filtering in CI#11714

Merged
frouioui merged 4 commits intovitessio:mainfrom
planetscale:fix-static-check-ci-go-filter
Nov 21, 2022
Merged

Fix files changes filtering in CI#11714
frouioui merged 4 commits intovitessio:mainfrom
planetscale:fix-static-check-ci-go-filter

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Nov 15, 2022 •
edited
Loading

Description

This Pull Request fixes the issue described in #11745. go.sum and go.mod are now two distinct filters in the workflows.

Related Issue(s)

Fixes #11745

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
test go.sum modification
f625c38 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 15, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui
test filter with different go.mod and go.sum rules
d71240e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
use different filters for go.mod and go.sum everywhere
156b77b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
deepthi reviewed Nov 16, 2022
View reviewed changes
@frouioui frouioui marked this pull request as draft November 16, 2022 18:00
@frouioui frouioui marked this pull request as ready for review November 16, 2022 18:17
@frouioui frouioui requested a review from deepthi November 16, 2022 18:17
@deepthi
Copy link
Collaborator

deepthi commented Nov 16, 2022

We have only 2 code owners for /test/. We should add a few more - maybe @deepthi and @mattlord at the directory level + @harshit-gangal for the java files.

@frouioui frouioui mentioned this pull request Nov 16, 2022
Closed
@frouioui
Copy link
Member Author

frouioui commented Nov 17, 2022

We have only 2 code owners for /test/. We should add a few more - maybe @deepthi and @mattlord at the directory level + @harshit-gangal for the java files.

@deepthi Done: #11762

@frouioui
clean up go.sum
3c3025b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the fix-static-check-ci-go-filter branch from 81bf582 to 3c3025b Compare November 17, 2022 00:32
@frouioui frouioui merged commit 813e757 into vitessio:main Nov 21, 2022
@frouioui frouioui deleted the fix-static-check-ci-go-filter branch November 21, 2022 06:59
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 21, 2022

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2022
@frouioui
Fix files changes filtering in CI (vitessio#11714)
4144205 
* test go.sum modification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test filter with different go.mod and go.sum rules

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* use different filters for go.mod and go.sum everywhere

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up go.sum

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2022
@frouioui
Fix files changes filtering in CI (vitessio#11714)
1765af9 
* test go.sum modification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test filter with different go.mod and go.sum rules

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* use different filters for go.mod and go.sum everywhere

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up go.sum

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
This was referenced Nov 21, 2022
Merged
Merged
@dbussink dbussink mentioned this pull request Nov 21, 2022
Merged
3 tasks
@rsajwani rsajwani mentioned this pull request Nov 26, 2022
Closed
24 tasks
frouioui added a commit that referenced this pull request Nov 28, 2022
@frouioui
Fix files changes filtering in CI (#11714) (#11778)
b2e5dd7 
* test go.sum modification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test filter with different go.mod and go.sum rules

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* use different filters for go.mod and go.sum everywhere

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up go.sum

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Nov 28, 2022
@frouioui
Fix files changes filtering in CI (#11714) (#11779)
ae1d8ba 
* Fix files changes filtering in CI (#11714)

* test go.sum modification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test filter with different go.mod and go.sum rules

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* use different filters for go.mod and go.sum everywhere

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up go.sum

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix format issue in .github/workflows/cluster_endtoend_18.yml

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajm188 ajm188 Awaiting requested review from ajm188

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@systay systay Awaiting requested review from systay

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Build/CI Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

go.sum changes not detected by the files changed filter in CI

2 participants

@frouioui @deepthi