Skip to content

Update latest protobuf#11782

Merged
harshit-gangal merged 1 commit intovitessio:mainfrom
planetscale:dbussink/regenerate-proto
Nov 21, 2022
Merged

Update latest protobuf#11782
harshit-gangal merged 1 commit intovitessio:mainfrom
planetscale:dbussink/regenerate-proto

Conversation

@dbussink
Copy link
Member

This needs to be regenerated since we updated the protobuf in go.mod but the CI job there never caught this.

Related Issue(s)

This was missed in #11741

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

This needs to be regenerated since we updated the protobuf in go.mod but
the CI job there never caught this.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 21, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@dbussink dbussink added Component: Build/CI dependencies Pull requests that update a dependency file Type: CI/Build labels Nov 21, 2022
@dbussink
Copy link
Member Author

#11714 avoids this in the future but #11741 was already too early for that due to merge ordering.

@harshit-gangal harshit-gangal merged commit aa8b503 into vitessio:main Nov 21, 2022
@harshit-gangal harshit-gangal deleted the dbussink/regenerate-proto branch November 21, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Build/CI dependencies Pull requests that update a dependency file Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants