Skip to content

Addition of a CI tool to detect dead links in test/config.json (#11668)#11713

Merged
frouioui merged 4 commits intovitessio:release-14.0from
planetscale:cp-11668-on-14
Nov 21, 2022
Merged

Addition of a CI tool to detect dead links in test/config.json (#11668)#11713
frouioui merged 4 commits intovitessio:release-14.0from
planetscale:cp-11668-on-14

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Nov 15, 2022

Description

This is a backport of #11668.

@frouioui @systay
Addition of a CI tool to detect dead links in test/config.json (vites…
036345e 
…sio#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@frouioui frouioui added the Backport This is a backport label Nov 15, 2022
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Nov 15, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui
apply go mod tidy
d8ac3c5 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui self-assigned this Nov 15, 2022
@frouioui
clean up workflows, backport 10710
66b642b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Copy Markdown
Member Author

frouioui commented Nov 16, 2022

This Pull Request backports most of the changes made in #10710. Those changes were made soon after v14.0.0 GA and were not backported onto release-14.0.

@frouioui frouioui mentioned this pull request Nov 17, 2022
Closed
@frouioui
Copy link
Copy Markdown
Member Author

frouioui commented Nov 17, 2022

Two tests are failing in Cluster (vtgate_queries) the failures have been written down in: #11763. They will be fixed in a later time before the release of v14.0.4. For now, the tests will be skipped.

@frouioui
skip failing tests
f382c8e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit 8fdd91c into vitessio:release-14.0 Nov 21, 2022
@frouioui frouioui deleted the cp-11668-on-14 branch November 21, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@frouioui frouioui

Labels

Backport This is a backport Component: Build/CI Type: Bug

Projects

v14.0.4
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frouioui @deepthi