Fixes to config file and flakiness fix for TestFloatValueDefault#10710
Merged
rohit-nayak-ps merged 3 commits intovitessio:mainfrom Jul 16, 2022
Merged
Fixes to config file and flakiness fix for TestFloatValueDefault#10710rohit-nayak-ps merged 3 commits intovitessio:mainfrom
rohit-nayak-ps merged 3 commits intovitessio:mainfrom
Conversation
…e query Signed-off-by: Manan Gupta <manan@planetscale.com>
…ctory which doesn't exist Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Contributor
Author
|
@deepthi The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR address 3 fixes to the CI -
TestFloatValueDefaultwas flaky since it didn't specifically order the results of the query leading to rows order being different from the expectations. The fix entails adding anorder byclause to make the row order deterministic.tabletgateway_cellaliasconfig fromconfig.jsonhas been removed. The package of tests being run by this config do not exist. We see the following lines in the CIvtgate_buffertest has been removed. Like ☝️, it too tries to run tests that don't exist.4.Related Issue(s)
Checklist
Deployment Notes