Skip to content

Fixes to config file and flakiness fix for TestFloatValueDefault#10710

Merged
rohit-nayak-ps merged 3 commits intovitessio:mainfrom
planetscale:some-random-fixes
Jul 16, 2022
Merged

Fixes to config file and flakiness fix for TestFloatValueDefault#10710
rohit-nayak-ps merged 3 commits intovitessio:mainfrom
planetscale:some-random-fixes

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

Description

This PR address 3 fixes to the CI -

  1. TestFloatValueDefault was flaky since it didn't specifically order the results of the query leading to rows order being different from the expectations. The fix entails adding an order by clause to make the row order deterministic.
  2. tabletgateway_cellalias config from config.json has been removed. The package of tests being run by this config do not exist. We see the following lines in the CI
    running tests for  vitess.io/vitess/go/test/endtoend/tabletgateway/cellalias
    [4243](https://github.com/vitessio/vitess/runs/7340550027?check_suite_focus=true#step:10:4244)
    no required module provides package vitess.io/vitess/go/test/endtoend/tabletgateway/cellalias; to add it:
    [4244](https://github.com/vitessio/vitess/runs/7340550027?check_suite_focus=true#step:10:4245)
         go get vitess.io/vitess/go/test/endtoend/tabletgateway/cellalias
    
  3. vtgate_buffer test has been removed. Like ☝️, it too tries to run tests that don't exist.4.
    2022/07/14 13:17:03 ============================================================
    [30](https://github.com/vitessio/vitess/runs/7340548461?check_suite_focus=true#step:9:31)
    2022/07/14 13:17:03 local.vtgate_buffer                     	FAIL (1 tries)
    [31](https://github.com/vitessio/vitess/runs/7340548461?check_suite_focus=true#step:9:32)
    2022/07/14 13:17:03 ============================================================
    [32](https://github.com/vitessio/vitess/runs/7340548461?check_suite_focus=true#step:9:33)
    2022/07/14 13:17:03 0 PASSED, 0 FLAKY, 1 FAILED, 0 SKIPPED
    2022/07/14 13:17:03 ============================================================
    [30](https://github.com/vitessio/vitess/runs/7340548461?check_suite_focus=true#step:9:31)
    2022/07/14 13:17:03 local.vtgate_buffer                     	FAIL (1 tries)
    [31](https://github.com/vitessio/vitess/runs/7340548461?check_suite_focus=true#step:9:32)
    2022/07/14 13:17:03 ============================================================
    [32](https://github.com/vitessio/vitess/runs/7340548461?check_suite_focus=true#step:9:33)
    2022/07/14 13:17:03 0 PASSED, 0 FLAKY, 1 FAILED, 0 SKIPPED
    

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

…e query

Signed-off-by: Manan Gupta <manan@planetscale.com>
…ctory which doesn't exist

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jul 16, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Copy Markdown
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GuptaManan100
Copy link
Copy Markdown
Contributor Author

@deepthi The vtgate_buffer test has to be removed from the required list of tests for us to be able to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants