Skip to content

Addition of a CI tool to detect dead links in test/config.json#11668

Merged
deepthi merged 8 commits intovitessio:mainfrom
planetscale:remove-unrequire-ci-clusters
Nov 15, 2022
Merged

Addition of a CI tool to detect dead links in test/config.json#11668
deepthi merged 8 commits intovitessio:mainfrom
planetscale:remove-unrequire-ci-clusters

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Nov 8, 2022

Description

This Pull Request fixes the issue detailed in #11667. It removes the tests in test/config.json that no longer exists and adds a go tool to automatically check that there is no dead links. This tool has been added to the CI workflow Static Code Checks Etc to automatically prevent the merge of dead links in test/config.json.

We most likely need to do a manual backport on all branches.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
Addition of a tool to detect unrequireed CI clusters in test/config.json
35f5a0f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 8, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

This was referenced Nov 8, 2022
Merged
Merged
GuptaManan100
GuptaManan100 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change.

@frouioui frouioui requested review from deepthi and mattlord November 9, 2022 17:24
deepthi
deepthi previously requested changes Nov 9, 2022
View reviewed changes
@frouioui
move mysql80 derived to queries/derived in config.json
b6e32d9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into remove-unrequire-ci-c…
04c615d 
…lusters

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui dismissed deepthi’s stale review November 9, 2022 19:17

Requested changes are addressed

@rsajwani
Copy link
Contributor

rsajwani commented Nov 11, 2022

Still some test failures are there which seems related to this PR..

@deepthi
Copy link
Collaborator

deepthi commented Nov 13, 2022

Still some test failures are there which seems related to this PR..

It seems to me that the derived test has not been running for some time in CI and is possibly broken for real.
cc @systay

@systay
test: clean the user table as well
3f5d510 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@frouioui
Fix flakyness in TestDerivedTableWithHaving
3b2ca23 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Nov 14, 2022
Open
@frouioui
Skip TestDerivedAggregationOnRHS
3d0efba 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into remove-unrequire-ci-c…
88d70a1 
…lusters

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Go mod tidy
a303cc2 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Member Author

frouioui commented Nov 14, 2022

It seems to me that the derived test has not been running for some time in CI and is possibly broken for real.

Should be fixed now. The clean up code was missing a table, a test was flaky, and a test is now skipped and will be fixed later (#11703).

@frouioui frouioui requested a review from deepthi November 14, 2022 19:51
mattlord
mattlord approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@deepthi deepthi merged commit 56dc40f into vitessio:main Nov 15, 2022
@deepthi deepthi deleted the remove-unrequire-ci-clusters branch November 15, 2022 16:28
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 15, 2022

I was unable to backport this Pull Request to the following branches: release-14.0, release-13.0, release-15.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Nov 15, 2022
@frouioui @systay
Addition of a CI tool to detect dead links in test/config.json (vites…
72ff005 
…sio#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 15, 2022
@frouioui @systay
Addition of a CI tool to detect dead links in test/config.json (vites…
036345e 
…sio#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
This was referenced Nov 15, 2022
Merged
Merged
frouioui added a commit that referenced this pull request Nov 16, 2022
@frouioui @systay
Addition of a CI tool to detect dead links in test/config.json (#11668)…
1a2f37c 
… (#11712)

* Addition of a CI tool to detect dead links in test/config.json (#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* apply go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@frouioui @systay
Addition of a CI tool to detect dead links in test/config.json (vites…
bc75d7d 
…sio#11668) (vitessio#11712)

* Addition of a CI tool to detect dead links in test/config.json (vitessio#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* apply go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit that referenced this pull request Nov 17, 2022
@frouioui @systay
[release-15.0] Remove Launchable in the workflows (#11669)
0fa4997 
* Remove launchable in release-15.0

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Addition of a CI tool to detect dead links in test/config.json (#11668) (#11712)

* Addition of a CI tool to detect dead links in test/config.json (#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* apply go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
frouioui added a commit that referenced this pull request Nov 21, 2022
@frouioui @systay
Addition of a CI tool to detect dead links in test/config.json (#11668)…
8fdd91c 
… (#11713)

* Addition of a CI tool to detect dead links in test/config.json (#11668)

* Addition of a tool to detect unrequireed CI clusters in test/config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move mysql80 derived to queries/derived in config.json

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: clean the user table as well

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Fix flakyness in TestDerivedTableWithHaving

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestDerivedAggregationOnRHS

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* apply go mod tidy

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up workflows, backport 10710

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* skip failing tests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

+2 more reviewers

@deepthi deepthi deepthi approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Build/CI Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dead links in test/config.json leading to CI potential failures

6 participants

@frouioui @rsajwani @deepthi @systay @mattlord @GuptaManan100