Skip to content

fix anchors for release notes and summary#11578

Merged
frouioui merged 2 commits intovitessio:release-15.0from
planetscale:fix-helpurls2
Oct 25, 2022
Merged

fix anchors for release notes and summary#11578
frouioui merged 2 commits intovitessio:release-15.0from
planetscale:fix-helpurls2

Conversation

@rsajwani
Copy link
Contributor

@rsajwani rsajwani commented Oct 25, 2022

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

running release script during release 15.0 changes the bookmarks for release notes and summary. This results in make them non-functional. This PR fix those bookmarks.

Also backup compression was having wrong value as defaults in release notes and summary. I fixed that as well.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani self-assigned this Oct 25, 2022
- [VTTablet Startup Flag Deletions](vttablet-startup-flag-deletions)
- [VTTablet Startup Flag Deprecations](vttablet-startup-flag-deprecations)
- [VTBackup Flag Deprecations](vtbackup-flag-deprecations)
- **[VTGate](vtgatevtgate)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be vtgate

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# are missing in the links in the summary otherwise looks good to me

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@frouioui frouioui added Forwardport to: main This will forward port the PR to the main branch Component: General Changes throughout the code base Type: Release labels Oct 25, 2022
@frouioui frouioui merged commit 552714d into vitessio:release-15.0 Oct 25, 2022
@frouioui frouioui deleted the fix-helpurls2 branch October 25, 2022 21:40
rsajwani added a commit to planetscale/vitess that referenced this pull request Oct 27, 2022
* fix anchors for release notes and summary

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* adding # to link

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
mattlord pushed a commit that referenced this pull request Oct 27, 2022
* fix anchors for release notes and summary

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* adding # to link

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Forwardport to: main This will forward port the PR to the main branch Type: Release

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants