[cherry-pick]fix anchors for release notes and summary (#11578)#11590
Merged
mattlord merged 1 commit intovitessio:mainfrom Oct 27, 2022
Merged
[cherry-pick]fix anchors for release notes and summary (#11578)#11590mattlord merged 1 commit intovitessio:mainfrom
mattlord merged 1 commit intovitessio:mainfrom
Conversation
* fix anchors for release notes and summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding # to link Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
rsajwani
added
Type: Enhancement
mattlord
reviewed
Oct 27, 2022
Comment on lines
+21
to
+24
| - [vtctl GetSchema --table-schema-only](#vtctl-getschema--table-schema-only) | ||
| - [Support for Additional Compressors and Decompressors During Backup & Restore](#support-for-additional-compressors-and-decompressors-during-backup--restore) | ||
| - [Independent OLAP and OLTP Transactional Timeouts](#independant-olap-and-oltp-transactional-timeouts) | ||
| - [Support for Specifying Group Information in Calls to VTGate](#support-for-specifying-group-information-in-calls-to-vtgate) |
Member
There was a problem hiding this comment.
These should be moved to their own sections or be placed under a Misc / Other section. They are not related to vdiff2.
| - [Flags](#flags) | ||
| - [VTTablet Flag Deletions](#vttablet-flag-deletions) | ||
| - [Vindex Interface](#vindex-interface) | ||
| - **[Deprecations](#deprecations)** |
Member
There was a problem hiding this comment.
If it's not too late, we could change this to deprecations and removals and also note the removal of all legacy sharding related code: #10278
mattlord
approved these changes
Oct 27, 2022
Member
mattlord
left a comment
mattlord
left a comment
There was a problem hiding this comment.
As discussed via Slack, my comments will be addressed in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bookmarks (anchor) for release notes and summary doc are broken. This PR will fix them.
Description
Cherry-pick #11578
Related Issue(s)
Checklist
Deployment Notes