Skip to content

[release-15.0] Plan order by COUNT(X) (#11420)#11497

Merged
frouioui merged 1 commit intovitessio:release-15.0from
planetscale:bp-11420-on-15
Oct 14, 2022
Merged

[release-15.0] Plan order by COUNT(X) (#11420)#11497
frouioui merged 1 commit intovitessio:release-15.0from
planetscale:bp-11420-on-15

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Oct 14, 2022

Description

This is a backport of #11420.

@frouioui
Plan order by COUNT(X) (vitessio#11420)
02a54a6 
* Plan order by Count()

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Clean up the new aggregation E2E test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Push more order by needs to the select list

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove unrequired code in TestOrderByCount

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove unwanted directory

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 14, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui mentioned this pull request Oct 14, 2022
Closed
100 tasks
@frouioui frouioui merged commit c44c56f into vitessio:release-15.0 Oct 14, 2022
@frouioui frouioui deleted the bp-11420-on-15 branch October 14, 2022 10:20
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport This is a backport Component: Query Serving Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frouioui @systay @GuptaManan100