Skip to content

Plan order by COUNT(X)#11420

Merged
frouioui merged 8 commits intovitessio:mainfrom
planetscale:fix-11219
Oct 13, 2022
Merged

Plan order by COUNT(X)#11420
frouioui merged 8 commits intovitessio:mainfrom
planetscale:fix-11219

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Oct 3, 2022 •
edited
Loading

Description

This code changed in this PR allows us to push more order by expressions to the select list. It fixes #11219 where the COUNT(x) was not pushed to the select list.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Plan order by Count()
7fb405c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 3, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui
Clean up the new aggregation E2E test
0ba7c3d 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Push more order by needs to the select list
617a3c9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review October 4, 2022 07:43
@frouioui
Remove unrequired code in TestOrderByCount
7e7e78a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
arthurschreiber
arthurschreiber reviewed Oct 6, 2022
View reviewed changes
@frouioui
Merge remote-tracking branch 'origin/main' into fix-11219
f31e56f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
remove unwanted directory
535317a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into fix-11219
fccc649 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into fix-11219
ff18d1a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit 2ee04b4 into vitessio:main Oct 13, 2022
@frouioui frouioui deleted the fix-11219 branch October 13, 2022 15:15
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 13, 2022

I was unable to backport this Pull Request to the following branches: release-15.0.

@frouioui frouioui mentioned this pull request Oct 13, 2022
Closed
100 tasks
frouioui added a commit to planetscale/vitess that referenced this pull request Oct 14, 2022
@frouioui
Plan order by COUNT(X) (vitessio#11420)
02a54a6 
* Plan order by Count()

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Clean up the new aggregation E2E test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Push more order by needs to the select list

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove unrequired code in TestOrderByCount

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove unwanted directory

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Oct 14, 2022
Merged
frouioui added a commit that referenced this pull request Oct 14, 2022
@frouioui
Plan order by COUNT(X) (#11420) (#11497)
c44c56f 
* Plan order by Count()

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Clean up the new aggregation E2E test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Push more order by needs to the select list

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove unrequired code in TestOrderByCount

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove unwanted directory

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@frouioui
Plan order by COUNT(X) (vitessio#11420) (vitessio#1316)
bfb5202 
* Plan order by Count()

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Clean up the new aggregation E2E test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Push more order by needs to the select list

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove unrequired code in TestOrderByCount

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove unwanted directory

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

Assignees

No one assigned

Labels

Component: Query Serving Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: group by X order by count(X) fails if X isn't a primary vindex?

3 participants

@frouioui @arthurschreiber @systay