Skip to content

collations: fix coercion semantics according to 8.0.31 changes#11487

Merged
vmg merged 2 commits intomainfrom
vmg/coercion
Oct 13, 2022
Merged

collations: fix coercion semantics according to 8.0.31 changes#11487
vmg merged 2 commits intomainfrom
vmg/coercion

Conversation

@vmg
Copy link
Copy Markdown
Collaborator

@vmg vmg commented Oct 13, 2022

Description

From the MySQL 8.0.31 release notes:

When comparing two string values with explicit COLLATE clauses, these should have the same collation, else the comparison should be rejected, but this was not always enforced.

This was breaking the build.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vmg
collations: fix coercion semantics according to 8.0.31 changes
d031a14 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 13, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui
Merge remote-tracking branch 'origin/main' into vmg/coercion
1b5a018 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vmg vmg merged commit 6561c40 into main Oct 13, 2022
@vmg vmg deleted the vmg/coercion branch October 13, 2022 14:09
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 13, 2022

I was unable to backport this Pull Request to the following branches: release-14.0, release-13.0, release-15.0.

@tanjinx tanjinx mentioned this pull request Nov 8, 2022
Merged
3 tasks
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@vmg @frouioui
collations: fix coercion semantics according to 8.0.31 changes (vites…
2e236b2 
…sio#11487) (vitessio#1149)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@rsajwani rsajwani mentioned this pull request Nov 26, 2022
Closed
24 tasks
@GuptaManan100 GuptaManan100 mentioned this pull request Nov 29, 2022
Merged
GuptaManan100 pushed a commit to planetscale/vitess that referenced this pull request Nov 29, 2022
@vmg @frouioui @GuptaManan100
collations: fix coercion semantics according to 8.0.31 changes (vites…
487ad07 
…sio#11487)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 pushed a commit to planetscale/vitess that referenced this pull request Nov 29, 2022
@vmg @frouioui @GuptaManan100
collations: fix coercion semantics according to 8.0.31 changes (vites…
5a3ab1b 
…sio#11487)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 mentioned this pull request Nov 29, 2022
Merged
GuptaManan100 pushed a commit to planetscale/vitess that referenced this pull request Nov 29, 2022
@vmg @frouioui @GuptaManan100
collations: fix coercion semantics according to 8.0.31 changes (vites…
7b1f688 
…sio#11487)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 mentioned this pull request Nov 29, 2022
Merged
GuptaManan100 added a commit that referenced this pull request Nov 29, 2022
@GuptaManan100 @vmg @frouioui
collations: fix coercion semantics according to 8.0.31 changes (#11487)…
91af0b9 
… (#11834)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
GuptaManan100 added a commit that referenced this pull request Nov 29, 2022
@GuptaManan100 @vmg @frouioui
collations: fix coercion semantics according to 8.0.31 changes (#11487)…
9942139 
… (#11835)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
GuptaManan100 added a commit that referenced this pull request Nov 29, 2022
@GuptaManan100 @vmg @frouioui
collations: fix coercion semantics according to 8.0.31 changes (#11487)…
f55765c 
… (#11836)

Signed-off-by: Vicent Marti <vmg@strn.cat>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbussink dbussink dbussink approved these changes

@systay systay systay approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees

No one assigned

Labels

Component: Query Serving Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vmg @dbussink @systay @frouioui