k8s: Make vtctld a replication controller, and other fixes.#1149
Merged
enisoc merged 1 commit intovitessio:masterfrom Sep 30, 2015
Merged
k8s: Make vtctld a replication controller, and other fixes.#1149enisoc merged 1 commit intovitessio:masterfrom
enisoc merged 1 commit intovitessio:masterfrom
Conversation
vtctld should be a replication controller rather than a single pod, so it gets restarted if the node fails. Also made other fixes as suggested in a review by some Kubernetes folks.
enisoc
added a commit
that referenced
this pull request
Sep 30, 2015
k8s: Make vtctld a replication controller, and other fixes.
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 16, 2022
…sio#11487) (vitessio#1149) Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thompsonja
vtctld should be a replication controller rather than a single pod,
so it gets restarted if the node fails.
Also made other fixes as suggested in a review by some Kubernetes folks.