Skip to content

Fix the script check_make_sizegen#11465

Merged
deepthi merged 4 commits intovitessio:release-15.0from
planetscale:fix-check-make-sizegen
Oct 12, 2022
Merged

Fix the script check_make_sizegen#11465
deepthi merged 4 commits intovitessio:release-15.0from
planetscale:fix-check-make-sizegen

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Oct 11, 2022

Description

This PR fixes and simplifies the check_make_sizegen script. It was previously failing as we were moving all the cache_file to the /tmp folder. With this change, the script has a similar structure as the check_make_proto script and runs correctly.

The failures could be observed in the CI, although the build was still successful.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Fix check_make_sizegen
33cb8fb 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 11, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

deepthi
deepthi reviewed Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Can we collect status from each check and fail at the end if one or more have failed?
cc @rohit-nayak-ps

@frouioui
Copy link
Copy Markdown
Member Author

frouioui commented Oct 11, 2022

Can we collect status from each check and fail at the end if one or more have failed?

@deepthi, we can and we should. I'll update this PR.

@frouioui frouioui marked this pull request as draft October 11, 2022 16:52
@frouioui
Apply review suggestion
6ea796c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Fail the static_check_etc workflow when a script fails
e3df0b3 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Remove test code
02e380f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review October 12, 2022 12:48
ajm188
ajm188 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 4a49da2 into vitessio:release-15.0 Oct 12, 2022
@deepthi deepthi deleted the fix-check-make-sizegen branch October 12, 2022 18:59
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 12, 2022

I was unable to backport this Pull Request to the following branches: release-14.0, release-13.0, release-12.0.

@vitess-bot vitess-bot bot mentioned this pull request Oct 12, 2022
Merged
frouioui added a commit that referenced this pull request Oct 13, 2022
@vitess-bot @frouioui
[main] Fix the script check_make_sizegen (#11465) (#11478)
0f13f42 
* Fix check_make_sizegen

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply review suggestion

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fail the static_check_etc workflow when a script fails

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove test code

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Oct 13, 2022
@frouioui
Fix the script check_make_sizegen (vitessio#11465)
fe62f41 
* Fix check_make_sizegen

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply review suggestion

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fail the static_check_etc workflow when a script fails

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove test code

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Oct 13, 2022
Merged
frouioui added a commit that referenced this pull request Oct 19, 2022
@frouioui
Fix the script check_make_sizegen (#11465) (#11486)
b200656 
* Fix check_make_sizegen

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply review suggestion

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fail the static_check_etc workflow when a script fails

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove test code

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Oct 26, 2022
Closed
100 tasks
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@maxenglander @vitess-bot @frouioui
[main] Fix the script check_make_sizegen (vitessio#11465) (vitessio…
e3e6991 
…#11478) (vitessio#1198)

* Fix check_make_sizegen

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply review suggestion

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fail the static_check_etc workflow when a script fails

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove test code

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay Awaiting requested review from systay

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

2 more reviewers

@deepthi deepthi deepthi left review comments

@ajm188 ajm188 ajm188 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Build/CI Forwardport to: main This will forward port the PR to the main branch Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frouioui @deepthi @ajm188