Add callerid support for txlogz and querylogz#1198
Merged
guokeno0 merged 9 commits intovitessio:masterfrom Oct 11, 2015
Merged
Conversation
added 6 commits
October 9, 2015 18:20
Contributor
Author
|
This is the back-port from internal commit |
go/vt/tabletserver/querylogz_test.go
Outdated
Contributor
There was a problem hiding this comment.
This should be context.Background(). Apparently TODO is to be used only for non-text code.
Contributor
|
lgtm. one comment. |
guokeno0
added a commit
that referenced
this pull request
Oct 11, 2015
Add callerid support for txlogz and querylogz
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 16, 2022
…#11478) (vitessio#1198) * Fix check_make_sizegen Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove test code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Max Englander <max@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.