Skip to content

Code freeze of release-15.0#11427

Merged
frouioui merged 1 commit intorelease-15.0from
release-15.0-code-freeze-1
Oct 4, 2022
Merged

Code freeze of release-15.0#11427
frouioui merged 1 commit intorelease-15.0from
release-15.0-code-freeze-1

Conversation

@rsajwani
Copy link
Contributor

@rsajwani rsajwani commented Oct 4, 2022 •
edited
Loading

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

This PR is to code freeze release 15.0 branch.

Related Issue(s)

#11425

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 4, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani self-assigned this Oct 4, 2022
@rsajwani rsajwani added Component: General Changes throughout the code base Type: Release labels Oct 4, 2022
@frouioui frouioui marked this pull request as ready for review October 4, 2022 02:18
@rsajwani @frouioui
Code freeze of release-15.0
138f092 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the release-15.0-code-freeze-1 branch from 20a4767 to 138f092 Compare October 4, 2022 04:14
@frouioui frouioui merged commit 0c257dd into release-15.0 Oct 4, 2022
@frouioui frouioui deleted the release-15.0-code-freeze-1 branch October 4, 2022 04:17
deepthi pushed a commit that referenced this pull request Oct 17, 2022
@notfelineit @rsajwani @dgraham
[VTAdmin] Topology Browser (#11496)
62bb228 
* Code freeze of release-15.0 (#11427)

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Add web side of topology components

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add GetTopologyPath

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add protos

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add comment explaining why name is not needed at toplevel topo path

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add GetTopologyPath to vtadmin

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Modify node code for non recursive

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add expand button

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Update logic for GetTopologyPath

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Render correct depth for nodes

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add tests TestGetTopologyPath

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add GetTopologyPath command

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Run lint prettier fix

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Consolidate DecodeContent to vt/topo package - can't put in vt/topo/topoproto because of import cycle

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Add rbac check for TopologyResource

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Update web/vtadmin/src/api/http.ts

Co-authored-by: David Graham <david.malcom.graham@gmail.com>
Signed-off-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>

* Update DecodeContent of zkcmd.go

Signed-off-by: notfelineit <notfelineit@gmail.com>

* Update help text

Signed-off-by: notfelineit <notfelineit@gmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Co-authored-by: David Graham <david.malcom.graham@gmail.com>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

Assignees

@rsajwani rsajwani

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsajwani @frouioui