Merged
Conversation
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
notfelineit
commented
Oct 14, 2022
notfelineit
commented
Oct 14, 2022
…rowser Signed-off-by: notfelineit <notfelineit@gmail.com>
frouioui
reviewed
Oct 14, 2022
ajm188
reviewed
Oct 14, 2022
Contributor
ajm188
left a comment
There was a problem hiding this comment.
We're also missing the cli command to correspond with the VtctldServer method
Contributor
Author
|
@ajm188 I wasn't sure if we wanted another cmd like the topocat one instead of this one for the command line client. I'll go ahead and add this one though. |
Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
…opoproto because of import cycle Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
dgraham
approved these changes
Oct 14, 2022
Co-authored-by: David Graham <david.malcom.graham@gmail.com> Signed-off-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
…into frances/topo-browser Signed-off-by: notfelineit <notfelineit@gmail.com>
Signed-off-by: notfelineit <notfelineit@gmail.com>
Collaborator
|
Upgrade/downgrade test failures are because we upgraded golang on release-15 to 1.18.7. |
deepthi
approved these changes
Oct 17, 2022
Contributor
|
I was unable to backport this Pull Request to the following branches: |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the topology browser in VTAdmin. In doing so, it implements
VtctldServer.GetTopologyPath. Given apath,GetTopologyPathreturns the file located there in the topology server.Web Topology Browser
Only the root topology directories are loaded at first. This has the same behavior as the topology browser in
vtctld2. "Nodes" can be expanded if they are not a "terminal" node (a file node).GetTopologyPath(path)is only called when theExpandbutton is clicked, and only for that specific path.The graph is then built recursively with only the paths that have been expanded so far.
VTAdmin example:

Related Issue(s)
Checklist
Deployment Notes
N/A