revert default compression engine#11029
Merged
deepthi merged 3 commits intovitessio:mainfrom Aug 19, 2022
Merged
Conversation
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
deepthi
approved these changes
Aug 17, 2022
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
LGTM. You will need to change the expected output for flags_test
rsajwani
approved these changes
Aug 17, 2022
rsajwani
previously requested changes
Aug 17, 2022
Contributor
rsajwani
left a comment
There was a problem hiding this comment.
You need to fix the test case failures
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Contributor
|
Run endtoend tests on Cluster (21) |
Collaborator
Looks like there might have been a problem with GH Actions. |
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Sep 21, 2022
* revert default compression engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> * fix flags test Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rvrangel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Renan Rangel rrangel@slack-corp.com
Description
As part of #10558, it seems we have changed the default compression engine from
pargziptopgzip. We can see here that this was the compressor used before. Currently we are defaulting topgzipand that is not intended as it was moved frompgzip=>pargzipin #7037This will make sure the default engine is
pargzipagain, as there is a considerable difference on resource usage when using the other engine.Related Issue(s)
Checklist
Deployment Notes