Skip to content

revert default compression engine#11029

Merged
deepthi merged 3 commits intovitessio:mainfrom
rvrangel:compression-default-engine
Aug 19, 2022
Merged

revert default compression engine#11029
deepthi merged 3 commits intovitessio:mainfrom
rvrangel:compression-default-engine

Conversation

@rvrangel
Copy link
Copy Markdown
Contributor

Signed-off-by: Renan Rangel rrangel@slack-corp.com

Description

As part of #10558, it seems we have changed the default compression engine from pargzip to pgzip. We can see here that this was the compressor used before. Currently we are defaulting to pgzip and that is not intended as it was moved from pgzip => pargzip in #7037

This will make sure the default engine is pargzip again, as there is a considerable difference on resource usage when using the other engine.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 17, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You will need to change the expected output for flags_test

Copy link
Copy Markdown
Contributor

@rsajwani rsajwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix the test case failures

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
@rsajwani
Copy link
Copy Markdown
Contributor

Run endtoend tests on Cluster (21)
isn't reporting any status .. not sure why .. it has backup/restore tests ... I think we should run them before sign-off..

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Aug 18, 2022

Run endtoend tests on Cluster (21)
isn't reporting any status .. not sure why .. it has backup/restore tests ... I think we should run them before sign-off..

Looks like there might have been a problem with GH Actions.
@rvrangel the only way to kick it is to make an empty commit and push again.

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
@deepthi deepthi dismissed rsajwani’s stale review August 19, 2022 13:46

Feedback has been addressed

@deepthi deepthi merged commit 1e6b05d into vitessio:main Aug 19, 2022
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Sep 21, 2022
* revert default compression engine

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>

* fix flags test

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Co-authored-by: Renan Rangel <rvrangel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants