backup: Use pargzip instead of pgzip for compression.#7037
Merged
deepthi merged 1 commit intovitessio:masterfrom Nov 17, 2020
Merged
backup: Use pargzip instead of pgzip for compression.#7037deepthi merged 1 commit intovitessio:masterfrom
deepthi merged 1 commit intovitessio:masterfrom
Conversation
enisoc
force-pushed
the
enisoc-pargzip
branch
from
72001a6 to
86a709a
Compare
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
enisoc
force-pushed
the
enisoc-pargzip
branch
from
86a709a to
d2f2d09
Compare
enisoc
changed the title
deepthi
reviewed
Nov 16, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
The changes look fine.
Do we have any before and after numbers on memory usage and time taken for backups?
Member
Author
|
In our environment, the time didn't change noticeably. With pgzip, memory usage would slowly grow throughout the backup process until OOMing. With pargzip, the memory usage is constant and insignificant compared with the memory used by mysqld. |
deepthi
approved these changes
Nov 17, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pargzip instead of pgzip for compression to fix #5613. We still use pgzip for decompression because we haven't seen problems in that phase.