Skip to content

revert default compression engine #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 3 commits into from
Aug 19, 2022
Merged

revert default compression engine #11029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c07aeb0
revert default compression engine
rvrangel Aug 17, 2022
87c70c1
fix flags test
rvrangel Aug 18, 2022
20cebcf
Merge branch 'master' into compression-default-engine
rvrangel Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/releasenotes/15_0_0_summary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ use-case. Here are the flags that control this feature

`--compression-engine-name` specifies the engine used for compression. It can have one of the following values

- pgzip (Default)
- pargzip
- pargzip (Default)
- pgzip
- lz4
- zstd
- external
Expand Down Expand Up @@ -205,4 +205,4 @@ send semi-sync ACKs. This ensures that any committed write exists in at least 2

#### FORMAT=vtexplain

With this new `explain` format, you can get an output that is very similar to the command line `vtexplain` app, but from a running `vtgate`, through a MySQL query.
With this new `explain` format, you can get an output that is very similar to the command line `vtexplain` app, but from a running `vtgate`, through a MySQL query.
2 changes: 1 addition & 1 deletion go/flags/endtoend/vtctld.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Usage of vtctld:
--catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified
--cell string cell to use
--ceph_backup_storage_config string Path to JSON config file for ceph backup storage. (default "ceph_backup_config.json")
--compression-engine-name string compressor engine used for compression. (default "pgzip")
--compression-engine-name string compressor engine used for compression. (default "pargzip")
--compression-level int what level to pass to the compressor (default 1)
--consolidator-stream-query-size int Configure the stream consolidator query size in bytes. Setting to 0 disables the stream consolidator. (default 2097152)
--consolidator-stream-total-size int Configure the stream consolidator total size in bytes. Setting to 0 disables the stream consolidator. (default 134217728)
Expand Down
2 changes: 1 addition & 1 deletion go/flags/endtoend/vtexplain.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Usage of vtexplain:
--builtinbackup_mysqld_timeout duration how long to wait for mysqld to shutdown at the start of the backup (default 10m0s)
--builtinbackup_progress duration how often to send progress updates when backing up large files (default 5s)
--catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified
--compression-engine-name string compressor engine used for compression. (default "pgzip")
--compression-engine-name string compressor engine used for compression. (default "pargzip")
--compression-level int what level to pass to the compressor (default 1)
--consolidator-stream-query-size int Configure the stream consolidator query size in bytes. Setting to 0 disables the stream consolidator. (default 2097152)
--consolidator-stream-total-size int Configure the stream consolidator total size in bytes. Setting to 0 disables the stream consolidator. (default 134217728)
Expand Down
2 changes: 1 addition & 1 deletion go/flags/endtoend/vttablet.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Usage of vttablet:
--builtinbackup_progress duration how often to send progress updates when backing up large files (default 5s)
--catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified
--ceph_backup_storage_config string Path to JSON config file for ceph backup storage. (default "ceph_backup_config.json")
--compression-engine-name string compressor engine used for compression. (default "pgzip")
--compression-engine-name string compressor engine used for compression. (default "pargzip")
--compression-level int what level to pass to the compressor (default 1)
--consolidator-stream-query-size int Configure the stream consolidator query size in bytes. Setting to 0 disables the stream consolidator. (default 2097152)
--consolidator-stream-total-size int Configure the stream consolidator total size in bytes. Setting to 0 disables the stream consolidator. (default 134217728)
Expand Down
2 changes: 1 addition & 1 deletion go/vt/mysqlctl/compression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const (
var (
compressionLevel = flag.Int("compression-level", 1, "what level to pass to the compressor")
// switch which compressor/decompressor to use
CompressionEngineName = flag.String("compression-engine-name", "pgzip", "compressor engine used for compression.")
CompressionEngineName = flag.String("compression-engine-name", "pargzip", "compressor engine used for compression.")
// use and external command to decompress the backups
ExternalCompressorCmd = flag.String("external-compressor", "", "command with arguments to use when compressing a backup")
ExternalCompressorExt = flag.String("external-compressor-extension", "", "extension to use when using an external compressor")
Expand Down