Skip to content

Fixes to config file and flakiness fix for TestFloatValueDefault #10710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 3 commits into from
Jul 16, 2022
Merged

Fixes to config file and flakiness fix for TestFloatValueDefault #10710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
777d8bb
test: fix flakiness in TestFloatValueDefault by adding ordering to th…
GuptaManan100 Jul 16, 2022
9981070
feat: remove tabletgateway_cellalias config since it points to a dire…
GuptaManan100 Jul 16, 2022
3d0a11c
feat: remove redundant test which tries to run test that doesn't exist
GuptaManan100 Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 0 additions & 106 deletions .github/workflows/cluster_endtoend_vtgate_buffer.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion go/test/endtoend/vtgate/unsharded/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ func TestFloatValueDefault(t *testing.T) {

utils.Exec(t, conn, `create table test_float_default (pos_f float default 2.1, neg_f float default -2.1);`)
defer utils.Exec(t, conn, `drop table test_float_default`)
utils.AssertMatches(t, conn, "select table_name, column_name, column_default from information_schema.columns where table_name = 'test_float_default'", `[[VARCHAR("test_float_default") VARCHAR("pos_f") TEXT("2.1")] [VARCHAR("test_float_default") VARCHAR("neg_f") TEXT("-2.1")]]`)
utils.AssertMatches(t, conn, "select table_name, column_name, column_default from information_schema.columns where table_name = 'test_float_default' order by column_default desc", `[[VARCHAR("test_float_default") VARCHAR("pos_f") TEXT("2.1")] [VARCHAR("test_float_default") VARCHAR("neg_f") TEXT("-2.1")]]`)
}

// TestRowCountExceeded tests the error message received when a query exceeds the row count specified
Expand Down
1 change: 0 additions & 1 deletion test/ci_workflow_gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ var (
"tabletmanager_throttler_custom_config",
"tabletmanager_tablegc",
"tabletmanager_consul",
"vtgate_buffer",
"vtgate_concurrentdml",
"vtgate_godriver",
"vtgate_gen4",
Expand Down
18 changes: 0 additions & 18 deletions test/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,15 +434,6 @@
"RetryMax": 1,
"Tags": []
},
"tabletgateway_cellalias": {
"File": "unused.go",
"Args": ["vitess.io/vitess/go/test/endtoend/tabletgateway/cellalias"],
"Command": [],
"Manual": false,
"Shard": "13",
"RetryMax": 1,
"Tags": []
},
"tabletgateway": {
"File": "unused.go",
"Args": ["vitess.io/vitess/go/test/endtoend/tabletgateway"],
Expand Down Expand Up @@ -612,15 +603,6 @@
"RetryMax": 2,
"Tags": []
},
"vtgate_buffer": {
"File": "unused.go",
"Args": ["vitess.io/vitess/go/test/endtoend/vtgate/buffer"],
"Command": [],
"Manual": false,
"Shard": "vtgate_buffer",
"RetryMax": 1,
"Tags": []
},
"vtgate_concurrentdml": {
"File": "unused.go",
"Args": ["vitess.io/vitess/go/test/endtoend/vtgate/concurrentdml"],
Expand Down