Be explicit about capturing the pointer#10765
Merged
rohit-nayak-ps merged 2 commits intovitessio:mainfrom Jul 20, 2022
Merged
Conversation
dbussink
requested review from
harshit-gangal,
mattlord and
systay
as code owners
vmg
approved these changes
Jul 20, 2022
The logic here was accidentally correct since we always in practice grab the pointer only on the last iteration, so it works. But the loop pointer linter catches this as an issue which is a good thing. Let's make it explicit how we capture this variable so there's no confusion and the linter also is happy about it. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
dbussink/avoid-linter-loop-error
branch
from
413258f to
60f4bfb
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic here was accidentally correct since we always in practice grab the pointer only on the last iteration, so it works.
But the loop pointer linter catches this as an issue which is a good thing. Let's make it explicit how we capture this variable so there's no confusion and the linter also is happy about it.
Related Issue(s)
This is the only other case the new linter alerts on in the codebase it looks apart from the bug fix that is in progress in #10739
Checklist