fix: change planner_version to planner-version everywhere

[systay]

Description

The new default for our flags will use hyphens instead of underscore, so this PR changes planner_version to planner-version everywhere.

Should be backported to r14

Related Issue(s)

Docs change: vitessio/website#1047
#10420

Checklist

• "Backport me!" label has been added if this change should be backported
• Tests were added or are not required
• Documentation was added or is not required

[github-actions]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
• If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.

[rohit-nayak-ps]

TestHelpOutput is failing and needs to be fixed for the new flags. @systay

[rohit-nayak-ps]

I presume this will also fix the current panic in main?

rohit@rohit-ubuntu:~/vitess-ps$ vtexplain
vtexplain flag redefined: planner_version
panic: vtexplain flag redefined: planner_version

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc000116120, {0x1872fe8, 0xc000486310}, {0x13e0f63, 0xf}, {0x1437603, 0x66})
	flag/flag.go:879 +0x2f4
flag.(*FlagSet).StringVar(...)
	flag/flag.go:762
flag.(*FlagSet).String(0x58?, {0x13e0f63, 0xf}, {0x13d207f, 0x4}, {0x1437603, 0x66})
	flag/flag.go:775 +0xac
flag.String(...)
	flag/flag.go:782
main.init()
	vitess.io/vitess/go/cmd/vtexplain/vtexplain.go:54 +0x4aa

[ajm188]

No, because it's defined twice (still) here. We should remove the one in cmd/vtexplain since it imports that package and will still show up in the help (post v14, we'll be able to tidy this up in a more sane way)

[ajm188]

hero

[ajm188]

so strange

fixed

[deepthi]

@ajm188 we have support for both forms for some flags like this:

	flagutil.DualFormatBoolVar(&enableConsolidator, "enable_consolidator", true, "This option enables the query consolidator.")

https://github.com/vitessio/vitess/blob/main/go/vt/vttablet/tabletserver/tabletenv/config.go#L158
Is that an option we should consider as part of flag migration? Then we won't care whether users use - or _ and avoid a whole class of issues.

[ajm188]

So, I'm actually against that convention, because it increases the matrix of possible ways you can "configure" vitess (e.g. "oh you said --some-flag but i'm using --some_flag, does that matter?" or "is --query_server-some-flag allowed? what about --query-server_some-flag? --query_server_some_flag?") better for there to be exactly one way to do things; avoids unnecessary complexity / opportunities for confusion/miscommunications