replace planner-version with planner_version in vtexplain#10420
Merged
systay merged 2 commits intovitessio:mainfrom Jun 3, 2022
Merged
replace planner-version with planner_version in vtexplain#10420systay merged 2 commits intovitessio:mainfrom
systay merged 2 commits intovitessio:mainfrom
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
GuptaManan100
approved these changes
Jun 3, 2022
frouioui
approved these changes
Jun 3, 2022
Member
|
On the doc, this page has to change as well |
Signed-off-by: Andres Taylor <andres@planetscale.com>
Collaborator
Author
|
This PR pairs very well together with vitessio/website#1039 |
Collaborator
|
I believe the new convention for flags is |
Contributor
|
++ please use |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vtexplain mistakenly used
planner-versioninstead ofplanner_version, note the underscore vs the hyphen.We want to keep the same flag that the vtgate is using, so this PR changes it to use the new flag.
Checklist