backport: change planner_version to planner-version everywhere#10466
Merged
systay merged 1 commit intovitessio:release-14.0from Jun 9, 2022
Merged
backport: change planner_version to planner-version everywhere#10466systay merged 1 commit intovitessio:release-14.0from
systay merged 1 commit intovitessio:release-14.0from
Conversation
systay
added
Type: Internal Cleanup
Component: Query Serving
Backport
systay
requested review from
ajm188,
derekperkins,
dkhenry,
frouioui,
harshit-gangal and
mattlord
as code owners
frouioui
approved these changes
Jun 8, 2022
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
…0453) * fix: change planner_version to planner-version everywhere Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: actually change the planner version on vtgate after checking Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move CheckPlannerVersionFlag out from vtgate Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move the global plannerVersion to be a field on the executor. think global, act local, yo Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: use the planner in the session first Signed-off-by: Andres Taylor <andres@planetscale.com> * test: use DEFAULT instead of 0 Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: re-add the planner-version flag to vtcombo Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
planner-version-r14
branch
from
3137726 to
8bf0dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport that changes the flag
planner_versiontoplanner-versionin a few places.Related Issue(s)
Backport of #10453
Checklist