delete RPCs that were deprecated in 13.0

[deepthi]

Description

Delete all references to the RPCs listed in the linked issue

Related Issue(s)

Fixes #8839

Checklist

• "Backport me!" label has been added if this change should be backported
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[mattlord]

Reading through this again: https://github.com/vitessio/enhancements/blob/main/veps/vep-1.md#example-2-deprecating-and-removing-an-obsolete-utility

Did we return an error e.g. if someone hit this code via a cmd-line command or API call? Does that matter in this case?

[deepthi]

Reading through this again: https://github.com/vitessio/enhancements/blob/main/veps/vep-1.md#example-2-deprecating-and-removing-an-obsolete-utility

Did we return an error e.g. if someone hit this code via a cmd-line command or API call? Does that matter in this case?

The older versions of the RPCs are only called from the command-line of older version vtctlds. We have no way of going back and printing a warning from there.
If they upgrade their vtctld to a newer version (13+), it uses the new RPCs.
The 2-version process we follow for RPCs is meant to make this completely transparent to users, so we don't even try to print a warning. IOW, as long as you stay +/-1 version among the various vitess components, there will be no errors. If you have version drift beyond that, then there are no guarantees. You will in fact get an error.

I don't think we officially support direct RPC calls to vttablets from clients right now, so we don't worry about that.

[mattlord]

I had a question about the vttablet fuzzer as there we seem to be removing rather than renaming/replacing, but otherwise this LGTM.

[mattlord]

Thanks again!