Skip to content

slack-vitess-r14.0.5: Revert "delete RPCs that were deprecated in 13.0 (#10099)"#61

Merged
timvaillancourt merged 7 commits intoslack-vitess-r14.0.5from
slack-vitess-r14.0.5-v12-rpcs
Mar 31, 2023
Merged

slack-vitess-r14.0.5: Revert "delete RPCs that were deprecated in 13.0 (#10099)"#61
timvaillancourt merged 7 commits intoslack-vitess-r14.0.5from
slack-vitess-r14.0.5-v12-rpcs

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented Mar 30, 2023

This reverts commit 4cc5000. This PR disabled legacy RPCs needed for reparenting from v12 vtctlds

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt marked this pull request as ready for review March 30, 2023 21:24
@timvaillancourt timvaillancourt added v14 upstream-revert An upstream revert labels Mar 30, 2023
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compared side by side with the upstream commit, looks good to me. Thanks Tim!

@timvaillancourt timvaillancourt merged commit 3dbe433 into slack-vitess-r14.0.5 Mar 31, 2023
@timvaillancourt timvaillancourt deleted the slack-vitess-r14.0.5-v12-rpcs branch March 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream-revert An upstream revert v14

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants