Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing INTERSTITIALS_PRIMARY_RESUMED after Event with CUE ONCE #6911

Closed
5 tasks done
matvp91 opened this issue Dec 12, 2024 · 1 comment · Fixed by #6915
Closed
5 tasks done

Missing INTERSTITIALS_PRIMARY_RESUMED after Event with CUE ONCE #6911

matvp91 opened this issue Dec 12, 2024 · 1 comment · Fixed by #6915
Labels
Bug Confirmed Bug report confirmed or reproduced.
Milestone

Comments

@matvp91
Copy link
Contributor

matvp91 commented Dec 12, 2024

What version of Hls.js are you using?

v1.6.0-beta.2

What browser (including version) are you using?

Chrome 131.0.6778.139

What OS (including version) are you using?

macOS

Test stream

No response

Configuration

{
  "debug": true,
  "enableWorker": true,
  "lowLatencyMode": true,
  "backBufferLength": 90
}

Additional player setup steps

No response

Checklist

Steps to reproduce

  1. Go to https://hlsjs-dev.video-dev.org/demo/, make sure it uses revision v1.6.0-beta.2.0.canary.10830.
  2. Generate a VOD playlist with an interstitial scheduled at time 10
curl --location 'https://stitcher.superstreamer.xyz/session' \
--header 'Content-Type: application/json' \
--data '{
  "uri": "https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8",
  "expiry": 15552000,
  "interstitials": [{
    "time": 10,
    "assets": [{
      "uri": "https://stream.mux.com/LewmZ1t6udxplSbjJglUJNvaAEscrAfzgLyzxw4f4Fo.m3u8"
    }]
  }]
}'
  1. Load the master playlist from the response, see url.
  2. Open console in the dev build
[Hls.Events.INTERSTITIAL_STARTED, Hls.Events.INTERSTITIAL_ENDED, Hls.Events.INTERSTITIALS_PRIMARY_RESUMED].forEach(event => {
  hls.on(event, () => {
    console.log("event log", event);
  });
});

Expected behaviour

The INTERSTITIALS_PRIMARY_RESUMED event shall be logged as well. In the sample, only the INTERSTITIAL_STARTED and INTERSTITIAL_ENDED are logged to console.

What actually happened?

There's no INTERSTITIALS_PRIMARY_RESUMED event being fired when transitioning from the interstitial to primary content.

Console output

N/A

Chrome media internals output

No response

@matvp91 matvp91 added Bug Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Dec 12, 2024
@robwalch robwalch changed the title Missing INTERSTITIALS_PRIMARY_RESUMED Missing INTERSTITIALS_PRIMARY_RESUMED after Event with CUE ONCE Dec 17, 2024
@robwalch robwalch added Confirmed Bug report confirmed or reproduced. and removed Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Dec 17, 2024
@robwalch robwalch added this to the 1.6.0 milestone Dec 17, 2024
@robwalch robwalch moved this from Todo to In Progress in HLS.js Interstitials Dec 17, 2024
@robwalch
Copy link
Collaborator

@robwalch robwalch added the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Dec 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in HLS.js Interstitials Dec 19, 2024
@robwalch robwalch removed the Verify Fixed An unreleased bug fix has been merged and should be verified before closing. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed Bug report confirmed or reproduced.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants