-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When an interstitial has X-CUE="ONCE", the resume offset is ignored #6983
Comments
Hi @matvp91,
Did you mean "ONCE"? "X-CUE" was promoted to a first class EXT-X-DATERANGE attribute: "CUE" with Trigger Identifiers PRE, POST, and ONCE (all caps). When you are reproducing this issue, at what point is the client joining the live stream: before or mid interstitial? If joining before, what is the latency before and after interstitial playback? I created a live stream with an interstitial matching these attributes and could not reproduce the issue in dev. The stream began with 6 seconds of latency and resumed with the same amount. The interstitial played for only 20 seconds of it's 37 second duration. Have you tried latest dev? This looks like it was resolved with the fix for #6911: |
I rely on beta 2 from npm, which does not include the PR above. I have yet to try the latest dev branch but very likely we caught this with #6911. I'll have an answer for you next week. |
This should be fixed in https://github.com/video-dev/hls.js/releases/tag/v1.6.0-beta.3 |
What version of Hls.js are you using?
v1.6.0-beta.2
What browser (including version) are you using?
132.0.6834.111
What OS (including version) are you using?
macOS 15
Test stream
N/A
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
As per spec:
I've simulated a live stream with primary content and short, linear, ad pods in between. For each ad pod, there is an interstitial scheduled for "ad replacement" purposes.
The interstitial above correctly respects the
X-PLAYOUT-LIMIT
offset but once we addX-CUE="once"
, the playout limit is no longer respected. For reference, I'll add your comment from a PM here: "the schedule is being updated to remove the interstitial and this is interfering with resumption offset".Expected behaviour
Respect the resumption offset unrelated to
X-CUE
.What actually happened?
The resumption offset is ignored.
Console output
Chrome media internals output
The text was updated successfully, but these errors were encountered: