Trigger INTERSTITIALS_PRIMARY_RESUMED after ending interstitial with CUE ONCE #6915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Trigger
INTERSTITIALS_PRIMARY_RESUMEDafter ending interstitial with CUE ONCEWhy is this Pull Request needed?
The handling of CUE ONCE involved removal of current (ended) interstitial from the schedule followed by a recursive call to
setSchedulePosition. This recursive call preventedINTERSTITIALS_PRIMARY_RESUMEDfrom being triggered because the the context of the current (ended) item was lost, leading toattachPrimarybeing called withfromItemofnull. Now the method has two parts, so that when the schedule is changed after ending an interstitial, the next item can advance with the context of the last item to have played.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Resolves #6911
Checklist