skip heartbeat for tool #4177
Merged
skip heartbeat for tool #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
pengweisong,
cangfengzhs,
HarrisChu,
liuyu85cn,
panda-sheep and
SuperYoko
critical27
added
ready-for-testing
pengweisong
previously approved these changes
Apr 19, 2022
SuperYoko
previously approved these changes
Apr 19, 2022
|
The test case failed, hold on a sec. Still compiling... |
critical27
dismissed stale reviews from HarrisChu, SuperYoko, and pengweisong
via
1a1401f
HarrisChu
approved these changes
Apr 19, 2022
SuperYoko
approved these changes
Apr 19, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Apr 20, 2022
Co-authored-by: Sophie <[email protected]>
Sophie-Xie
added a commit
that referenced
this pull request
Apr 20, 2022
* fix issue 4152 (#4158) * Fix optional of multi-match (#4159) * fix optional of multi-match * format Co-authored-by: Sophie <[email protected]> * Fix incompatibility imported by #4116 (#4165) * Add SaveGraphVersionProcessor to separate client version check and version saving * Update error code * Update error code * optimizer path (#4162) * optimizer multi-shortest path * new algorithm * fix error * skip heartbeat for tool (#4177) Co-authored-by: Sophie <[email protected]> * Fix/null pattern expression input (#4180) * Move input rows of Traverse and AppendVertices. * Avoid skip validate pattern expression with aggregate. * Fix case. * Revert "Move input rows of Traverse and AppendVertices." This reverts commit 7fd1d38. Co-authored-by: Sophie <[email protected]> * fix wrong space key after dropping hosts (#4182) Co-authored-by: Sophie <[email protected]> * fix vertex is missing from snapshot (#4189) Co-authored-by: Sophie <[email protected]> * Expression is stateful to store the result of evaluation, so we can't… (#4190) * Expression is stateful to store the result of evaluation, so we can't share it inter threads. * Fix defef nullptr. Co-authored-by: jie.wang <[email protected]> Co-authored-by: kyle.cao <[email protected]> Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: shylock <[email protected]> Co-authored-by: liwenhui-soul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
#3855 only handle startup, we just skip heartbeat for tools all the time to avoid the annoying "UNKNOWN" hosts
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe:
Not related