Fix optional of multi-match #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
approved these changes
Apr 15, 2022
Shylock-Hg
reviewed
Apr 15, 2022
| @@ -83,11 +83,19 @@ Status MatchPlanner::connectMatchPlan(SubPlan& queryPlan, MatchClauseContext* ma | |||
| } | |||
| if (!intersectedAliases.empty()) { | |||
| if (matchCtx->isOptional) { | |||
| // connect LeftJoin match filter | |||
| if (matchCtx->where != nullptr) { | |||
There was a problem hiding this comment.
What will happen when filter reference variable outside current match cluase if you don't delay the filter
There was a problem hiding this comment.
MATCH (a)--(b)--(c)
OPTIONAL MATCH (a)--(b)--(d) WHERE d.prop>c.prop
RETURN count(*) AS count
This statement is currently not fixed, count will return 0.
There was a problem hiding this comment.
If this hotfix introduces a new bug , it's not necessary to merge. WDYT? @CPWstatic
There was a problem hiding this comment.
Do you mean the previous hotfix or this one?
CPWstatic
approved these changes
Apr 15, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Apr 18, 2022
* fix optional of multi-match * format Co-authored-by: Sophie <[email protected]>
Sophie-Xie
added a commit
that referenced
this pull request
Apr 20, 2022
* fix optional of multi-match * format Co-authored-by: Sophie <[email protected]>
Sophie-Xie
added a commit
that referenced
this pull request
Apr 20, 2022
* fix issue 4152 (#4158) * Fix optional of multi-match (#4159) * fix optional of multi-match * format Co-authored-by: Sophie <[email protected]> * Fix incompatibility imported by #4116 (#4165) * Add SaveGraphVersionProcessor to separate client version check and version saving * Update error code * Update error code * optimizer path (#4162) * optimizer multi-shortest path * new algorithm * fix error * skip heartbeat for tool (#4177) Co-authored-by: Sophie <[email protected]> * Fix/null pattern expression input (#4180) * Move input rows of Traverse and AppendVertices. * Avoid skip validate pattern expression with aggregate. * Fix case. * Revert "Move input rows of Traverse and AppendVertices." This reverts commit 7fd1d38. Co-authored-by: Sophie <[email protected]> * fix wrong space key after dropping hosts (#4182) Co-authored-by: Sophie <[email protected]> * fix vertex is missing from snapshot (#4189) Co-authored-by: Sophie <[email protected]> * Expression is stateful to store the result of evaluation, so we can't… (#4190) * Expression is stateful to store the result of evaluation, so we can't share it inter threads. * Fix defef nullptr. Co-authored-by: jie.wang <[email protected]> Co-authored-by: kyle.cao <[email protected]> Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Doodle <[email protected]> Co-authored-by: shylock <[email protected]> Co-authored-by: liwenhui-soul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4154
Description:
How do you solve it?
The calculation of
Filterbefore and afterInnerJoin/Cartesianare equivalent if the Filter can be delay.The calculation of
Filterbefore and afterLeftJoinare not equivalent, bczLeftJoinalways keep the left table rows.So the correct solution is to introduce all visible variables via
Argumentand computes theFilterbeforeLeftJoin.This pr currently only fixes the case where
Filternot referencing variables outside the definitions in the current match pattern.Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: