Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed_bug_3853 #4116

Merged
merged 4 commits into from
Apr 6, 2022
Merged

fixed_bug_3853 #4116

merged 4 commits into from
Apr 6, 2022

Conversation

zhaohaifei
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#3853

Description:

show hosts sometimes doesn't show version.

How do you solve it?

Reason: When version writing fails, no error is reported.
Solution: report an error when fails.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....
Fixed the bug:sometimes show hosts don't display version.

@zhaohaifei zhaohaifei added ready-for-testing PR: ready for the CI test ready for review cherry-pick-v3.1 PR: need cherry-pick to this version labels Apr 3, 2022
@zhaohaifei zhaohaifei added this to the v3.1.0 milestone Apr 3, 2022
@zhaohaifei zhaohaifei changed the title fixed fixed_bug_3853 Apr 6, 2022
@Sophie-Xie Sophie-Xie merged commit 27066cc into vesoft-inc:master Apr 6, 2022
@zhaohaifei zhaohaifei deleted the fix_bug_3853 branch April 6, 2022 06:08
Sophie-Xie added a commit that referenced this pull request Apr 7, 2022
Co-authored-by: Sophie <[email protected]>
yixinglu pushed a commit that referenced this pull request Apr 7, 2022
* fix apply outdate membership change (#4107)

* fix apply outdate membership change

* fix transfer leader to '':0 cause crash

Co-authored-by: Sophie <[email protected]>

* add code for part peers backward compatible (#4101)

* add code for part peers backward compatible

* add balance keys

* fix bug: pass tests

* add gflag && ignore

* change int to int64_t

* chage to emplace

Co-authored-by: panda-sheep <[email protected]>
Co-authored-by: Sophie <[email protected]>

* fixed (#4116)

Co-authored-by: Sophie <[email protected]>

* move KW_CLEAR to unresolved keyword (#4118)

* Limits for add and recover balance data or zone balance jobs (#4104)

* If there are failed or stopped data balance or zone balance job, must firstly recover it

* address wenhaocs's comments

* address comments

* add more comments

* recover job

* add more ut

* adjust comment format

* adjust comment format

* adjust comment format

Co-authored-by: Doodle <[email protected]>
Co-authored-by: pengwei.song <[email protected]>
Co-authored-by: panda-sheep <[email protected]>
Co-authored-by: haifei.zhao <[email protected]>
CPWstatic pushed a commit that referenced this pull request Apr 18, 2022
* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code
Sophie-Xie pushed a commit that referenced this pull request Apr 18, 2022
* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code
Sophie-Xie pushed a commit that referenced this pull request Apr 20, 2022
* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code
Sophie-Xie added a commit that referenced this pull request Apr 20, 2022
* fix issue 4152 (#4158)

* Fix optional of multi-match (#4159)

* fix optional of multi-match

* format

Co-authored-by: Sophie <[email protected]>

* Fix incompatibility imported by #4116 (#4165)

* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code

* optimizer path (#4162)

* optimizer multi-shortest path

* new algorithm

* fix error

* skip heartbeat for tool (#4177)

Co-authored-by: Sophie <[email protected]>

* Fix/null pattern expression input (#4180)

* Move input rows of Traverse and AppendVertices.

* Avoid skip validate pattern expression with aggregate.

* Fix case.

* Revert "Move input rows of Traverse and AppendVertices."

This reverts commit 7fd1d38.

Co-authored-by: Sophie <[email protected]>

* fix wrong space key after dropping hosts (#4182)

Co-authored-by: Sophie <[email protected]>

* fix vertex is missing from snapshot (#4189)

Co-authored-by: Sophie <[email protected]>

* Expression is stateful to store the result of evaluation, so we can't… (#4190)

* Expression is stateful to store the result of evaluation, so we can't share it inter threads.

* Fix defef nullptr.

Co-authored-by: jie.wang <[email protected]>
Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: shylock <[email protected]>
Co-authored-by: liwenhui-soul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants