Skip to content

Comments

[training_utils] fix: Resolved bugs and conflicts in the fully async caused by multiple PRs#5100

Merged
wuxibin89 merged 3 commits intoverl-project:mainfrom
ZLiao097:fix_fully_async_agent
Feb 2, 2026
Merged

[training_utils] fix: Resolved bugs and conflicts in the fully async caused by multiple PRs#5100
wuxibin89 merged 3 commits intoverl-project:mainfrom
ZLiao097:fix_fully_async_agent

Conversation

@ZLiao097
Copy link
Contributor

@ZLiao097 ZLiao097 commented Jan 29, 2026

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Problem1: ConfigAttributeError('Missing key config\n full_key: config\n object_type=dict')
This error was introduced by this PR: dataset_config type was changed from DictConfig to DictConfigWrap in AgentLoopBase initialization (using dataset_config.config for passing), but the fully async agentloop failed to update dataset_config to DictConfigWrap, causing the error.

The following two problems were introduced by this PR:

Problem2: TypeError: got an unexpected keyword argument 'cuda_visible_devices'
The PR added cuda_visible_devices to vLLMHttpServer, but its subclass vLLMHttpServerForPartial in fully async was not updated accordingly, causing conflicts.

Problem3: KeyError: 'ASCEND_RT_VISIBLE_DEVICES'
The PR references the environment variable ASCEND_RT_VISIBLE_DEVICES in get_device_uuid but does not handle its absence or set a default value, leading to potential errors.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@ZLiao097 ZLiao097 force-pushed the fix_fully_async_agent branch from c26e0c0 to fe04340 Compare January 29, 2026 04:36
@tardis-key
Copy link
Collaborator

Could u confirm if there are any other places that also require this fix?

@Shangwei-Li
Copy link
Contributor

Would you please add CUDA_VISIBLE_DEVICES related fixes to this PR?

@ZLiao097
Copy link
Contributor Author

Could u confirm if there are any other places that also require this fix?

I've checked other potential error points.

@ZLiao097
Copy link
Contributor Author

Would you please add CUDA_VISIBLE_DEVICES related fixes to this PR?

Done.

@ZLiao097
Copy link
Contributor Author

@tardis-key I've additionally fixed two other conflict points and merged them into this PR. Please re-trigger the CI for me ;)

@ZLiao097
Copy link
Contributor Author

ZLiao097 commented Jan 29, 2026

Could u confirm if there are any other places that also require this fix?

I've checked other potential error points.

@tardis-key I've also checked the second problem – only one place needs modification.

@ZLiao097 ZLiao097 changed the title [training_utils] fix: Type error for parameter data_config in fully async agentloop [training_utils] fix: Resolved bugs and conflicts in the fully async agentloop caused by multiple PRs Jan 29, 2026
@ZLiao097 ZLiao097 changed the title [training_utils] fix: Resolved bugs and conflicts in the fully async agentloop caused by multiple PRs [training_utils] fix: Resolved bugs and conflicts in the fully async caused by multiple PRs Jan 29, 2026
@wuxibin89 wuxibin89 merged commit 72c109a into verl-project:main Feb 2, 2026
72 of 84 checks passed
amzfang pushed a commit to amzfang/verl that referenced this pull request Feb 3, 2026
…caused by multiple PRs (verl-project#5100)

### What does this PR do?

> Add **concise** overview of what this PR aims to achieve or
accomplish. Reference related GitHub issues and PRs that help with the
review.

**Problem1: ConfigAttributeError('Missing key config\n full_key:
config\n object_type=dict')**
This error was introduced by this
[PR](verl-project#5034): `dataset_config`
type was changed from `DictConfig` to `DictConfigWrap` in
`AgentLoopBase` initialization (using dataset_config.config for
passing), but the fully async agentloop failed to update
`dataset_config` to `DictConfigWrap`, causing the error.

The following two problems were introduced by this
[PR](verl-project#4280):

**Problem2: TypeError: got an unexpected keyword argument
'cuda_visible_devices'**
The PR added `cuda_visible_devices` to `vLLMHttpServer`, but its
subclass `vLLMHttpServerForPartial` in fully async was not updated
accordingly, causing conflicts.

**Problem3: KeyError: 'ASCEND_RT_VISIBLE_DEVICES'**
The PR references the environment variable `ASCEND_RT_VISIBLE_DEVICES`
in `get_device_uuid` but does not handle its absence or set a default
value, leading to potential errors.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [ ] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
Tjh-UKN pushed a commit to Tjh-UKN/verl that referenced this pull request Feb 13, 2026
…caused by multiple PRs (verl-project#5100)

### What does this PR do?

> Add **concise** overview of what this PR aims to achieve or
accomplish. Reference related GitHub issues and PRs that help with the
review.

**Problem1: ConfigAttributeError('Missing key config\n full_key:
config\n object_type=dict')**
This error was introduced by this
[PR](verl-project#5034): `dataset_config`
type was changed from `DictConfig` to `DictConfigWrap` in
`AgentLoopBase` initialization (using dataset_config.config for
passing), but the fully async agentloop failed to update
`dataset_config` to `DictConfigWrap`, causing the error.

The following two problems were introduced by this
[PR](verl-project#4280):

**Problem2: TypeError: got an unexpected keyword argument
'cuda_visible_devices'**
The PR added `cuda_visible_devices` to `vLLMHttpServer`, but its
subclass `vLLMHttpServerForPartial` in fully async was not updated
accordingly, causing conflicts.

**Problem3: KeyError: 'ASCEND_RT_VISIBLE_DEVICES'**
The PR references the environment variable `ASCEND_RT_VISIBLE_DEVICES`
in `get_device_uuid` but does not handle its absence or set a default
value, leading to potential errors.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [ ] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants