Skip to content

Comments

[trainer] fix: resolve dataset config in agent loop#5034

Merged
wuxibin89 merged 1 commit intoverl-project:mainfrom
yyDing1:fix_rl_config
Jan 28, 2026
Merged

[trainer] fix: resolve dataset config in agent loop#5034
wuxibin89 merged 1 commit intoverl-project:mainfrom
yyDing1:fix_rl_config

Conversation

@yyDing1
Copy link
Collaborator

@yyDing1 yyDing1 commented Jan 24, 2026

What does this PR do?

line 516: dataset_config=self.config.data

https://github.com/volcengine/verl/blob/772c224935d136b05f5f2d10ddaa6d3b7a41403c/verl/experimental/agent_loop/agent_loop.py#L509-L517

self.config.data may have unresolved arguments like 'tool_config_path': '${oc.select:actor_rollout_ref.rollout.multi_turn.tool_config_path, null}', which cannot be instantiated. This will cause error

*** omegaconf.errors.InterpolationResolutionError: TypeError raised while resolving interpolation: Index 'actor_rollout_ref' (str) is not an int

Solution:

Wrap it in DictConfigWrap, so that it will not be initialized in hydra resolve config.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly resolves an OmegaConf interpolation error by wrapping the dataset_config in a DictConfigWrap class to prevent premature resolution by Hydra. The changes are consistent and effectively address the issue. I've also identified a critical race condition in the AsyncLLMServerManager that is closely related to the code being changed and should be addressed.

@wuxibin89 wuxibin89 merged commit b63fe7f into verl-project:main Jan 28, 2026
78 of 84 checks passed
@yyDing1 yyDing1 deleted the fix_rl_config branch January 29, 2026 16:12
wuxibin89 pushed a commit that referenced this pull request Feb 2, 2026
…caused by multiple PRs (#5100)

### What does this PR do?

> Add **concise** overview of what this PR aims to achieve or
accomplish. Reference related GitHub issues and PRs that help with the
review.

**Problem1: ConfigAttributeError('Missing key config\n full_key:
config\n object_type=dict')**
This error was introduced by this
[PR](#5034): `dataset_config`
type was changed from `DictConfig` to `DictConfigWrap` in
`AgentLoopBase` initialization (using dataset_config.config for
passing), but the fully async agentloop failed to update
`dataset_config` to `DictConfigWrap`, causing the error.

The following two problems were introduced by this
[PR](#4280):

**Problem2: TypeError: got an unexpected keyword argument
'cuda_visible_devices'**
The PR added `cuda_visible_devices` to `vLLMHttpServer`, but its
subclass `vLLMHttpServerForPartial` in fully async was not updated
accordingly, causing conflicts.

**Problem3: KeyError: 'ASCEND_RT_VISIBLE_DEVICES'**
The PR references the environment variable `ASCEND_RT_VISIBLE_DEVICES`
in `get_device_uuid` but does not handle its absence or set a default
value, leading to potential errors.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [ ] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
amzfang pushed a commit to amzfang/verl that referenced this pull request Feb 3, 2026
…caused by multiple PRs (verl-project#5100)

### What does this PR do?

> Add **concise** overview of what this PR aims to achieve or
accomplish. Reference related GitHub issues and PRs that help with the
review.

**Problem1: ConfigAttributeError('Missing key config\n full_key:
config\n object_type=dict')**
This error was introduced by this
[PR](verl-project#5034): `dataset_config`
type was changed from `DictConfig` to `DictConfigWrap` in
`AgentLoopBase` initialization (using dataset_config.config for
passing), but the fully async agentloop failed to update
`dataset_config` to `DictConfigWrap`, causing the error.

The following two problems were introduced by this
[PR](verl-project#4280):

**Problem2: TypeError: got an unexpected keyword argument
'cuda_visible_devices'**
The PR added `cuda_visible_devices` to `vLLMHttpServer`, but its
subclass `vLLMHttpServerForPartial` in fully async was not updated
accordingly, causing conflicts.

**Problem3: KeyError: 'ASCEND_RT_VISIBLE_DEVICES'**
The PR references the environment variable `ASCEND_RT_VISIBLE_DEVICES`
in `get_device_uuid` but does not handle its absence or set a default
value, leading to potential errors.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [ ] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
Tjh-UKN pushed a commit to Tjh-UKN/verl that referenced this pull request Feb 13, 2026
…caused by multiple PRs (verl-project#5100)

### What does this PR do?

> Add **concise** overview of what this PR aims to achieve or
accomplish. Reference related GitHub issues and PRs that help with the
review.

**Problem1: ConfigAttributeError('Missing key config\n full_key:
config\n object_type=dict')**
This error was introduced by this
[PR](verl-project#5034): `dataset_config`
type was changed from `DictConfig` to `DictConfigWrap` in
`AgentLoopBase` initialization (using dataset_config.config for
passing), but the fully async agentloop failed to update
`dataset_config` to `DictConfigWrap`, causing the error.

The following two problems were introduced by this
[PR](verl-project#4280):

**Problem2: TypeError: got an unexpected keyword argument
'cuda_visible_devices'**
The PR added `cuda_visible_devices` to `vLLMHttpServer`, but its
subclass `vLLMHttpServerForPartial` in fully async was not updated
accordingly, causing conflicts.

**Problem3: KeyError: 'ASCEND_RT_VISIBLE_DEVICES'**
The PR references the environment variable `ASCEND_RT_VISIBLE_DEVICES`
in `get_device_uuid` but does not handle its absence or set a default
value, leading to potential errors.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [ ] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants