fix: Link ghostty-vt statically on Windows MSVC - #13171
Merged
Merged
Conversation
On MSVC, rustc resolves static=ghostty-vt to ghostty-vt.lib, which is the DLL import library rather than the static archive. That left release turbo.exe importing ghostty-vt.dll even though turborepo-ghostty-sys defaults to static linking. Use static=ghostty-vt-static on Windows MSVC so published @turbo/windows-* packages do not require a runtime ghostty-vt.dll sidecar. Fixes #13170 Co-authored-by: Anthony Shew <anthonyshew@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Co-authored-by: Anthony Shew <anthonyshew@users.noreply.github.com>
anthonyshew
pushed a commit
that referenced
this pull request
Jun 30, 2026
## Release v2.10.2-canary.1 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/28455389159) ### Changes - feat: Support devEngines packageManager in workspaces (#13150) (`9d94ae5`) - release(turborepo): 2.10.1-canary.3 (#13149) (`0d32225`) - feat: Update add package manager codemod (#13151) (`27ca962`) - feat: Update workspace package manager declarations (#13154) (`f878719`) - release(turborepo): 2.10.1 (#13156) (`8c3bbe4`) - docs: Prefer devEngines packageManager (#13155) (`6598f7c`) - fix: Install Zig for LSP builds (#13158) (`c1bc71f`) - ci: Pin macOS Rust builds to macOS 15 (#13167) (`16fe0a4`) - feat: Recognize nub as a package manager (#13120) (`782b168`) - fix: Preserve 3-level nested Bun lockfile entries during prune (#13168) (`799fa5a`) - fix: Avoid following nested symlinked cache outputs (#13166) (`502ceaf`) - feat: Add nub package manager support to JavaScript packages (#13169) (`53cddc8`) - fix: Link ghostty-vt statically on Windows MSVC (#13171) (`e950d71`) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
anthonyshew
pushed a commit
that referenced
this pull request
Jun 30, 2026
## Release v2.10.2 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/28458202079) ### Changes - release(turborepo): 2.10.1 (#13156) (`8c3bbe4`) - docs: Prefer devEngines packageManager (#13155) (`6598f7c`) - fix: Install Zig for LSP builds (#13158) (`c1bc71f`) - ci: Pin macOS Rust builds to macOS 15 (#13167) (`16fe0a4`) - feat: Recognize nub as a package manager (#13120) (`782b168`) - fix: Preserve 3-level nested Bun lockfile entries during prune (#13168) (`799fa5a`) - fix: Avoid following nested symlinked cache outputs (#13166) (`502ceaf`) - feat: Add nub package manager support to JavaScript packages (#13169) (`53cddc8`) - fix: Link ghostty-vt statically on Windows MSVC (#13171) (`e950d71`) - release(turborepo): 2.10.2-canary.1 (#13172) (`c597bb5`) - feat: Add nub to create-turbo options (#13173) (`82b1cf1`) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
Upstream libghostty-vt-sys 0.2.0 emits static=ghostty-vt, which MSVC resolves to ghostty-vt.lib (the DLL import library). That regresses the fix from #13171 and would leave turbo.exe depending on ghostty-vt.dll. Vendor libghostty-vt-sys 0.2.0 with the MSVC ghostty-vt-static link override via [patch.crates-io] until upstream includes the same fix. Co-authored-by: Anthony Shew <anthonyshew@users.noreply.github.com>
anthonyshew
added a commit
that referenced
this pull request
Jul 3, 2026
…ngs (#13205) ## Summary Switches Turborepo's Ghostty integration from vendored `turborepo-ghostty-sys` bindings to the upstream [`libghostty-vt`](https://crates.io/crates/libghostty-vt) / [`libghostty-vt-sys`](https://crates.io/crates/libghostty-vt-sys) crates, with a local patch for Windows MSVC static linking. ## Changes - Remove `crates/turborepo-ghostty-sys/` and ~10k lines of vendored FFI wrappers - Slim `turborepo-ghostty` down to Turborepo-specific glue (`Parser`, `TerminalWidget`, style conversion) - Add `[patch.crates-io]` for `libghostty-vt-sys` with MSVC `ghostty-vt-static` linking fix - **CI fix:** run the TUI on a dedicated OS thread — upstream Ghostty terminal types are `!Send`, so `tokio::task::spawn` no longer compiles ## Windows static linking Upstream `libghostty-vt-sys` 0.2.0 links `static=ghostty-vt`, which on MSVC resolves to the DLL import library. The patched crate links `ghostty-vt-static` instead, matching the prior `turborepo-ghostty-sys` fix (#13171). ## Notes - Zig is still required at build time (`libghostty-vt-sys` runs `zig build` against Ghostty sources) - Once upstream merges the MSVC static-link fix, we can drop the local `crates/libghostty-vt-sys/` patch --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Anthony Shew <anthonyshew@users.noreply.github.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MSVC, rustc resolves static=ghostty-vt to ghostty-vt.lib, which is the DLL import library rather than the static archive. That left release turbo.exe importing ghostty-vt.dll even though turborepo-ghostty-sys defaults to static linking.
Use static=ghostty-vt-static on Windows MSVC so published @turbo/windows-* packages do not require a runtime ghostty-vt.dll sidecar.
Fixes #13170