Conversation
Contributor
|
@Balance8 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Ensures Windows releases and the Windows native npm packages include required runtime DLL sidecars (e.g., ghostty-vt.dll) alongside turbo.exe, preventing “missing shared library” startup failures after install.
Changes:
- Copy any
.dllsidecars found next to the Windowsturbo.exeinto the packagedbin/directory during native npm package creation. - Extend unit coverage to validate DLL sidecars are included (case-insensitive
.dllhandling). - Update the release workflow to upload Windows
.dllsidecars with the Rust build artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/turbo-releaser/src/operations.ts | Copies Windows DLL sidecars into the native package bin/ directory next to turbo.exe. |
| packages/turbo-releaser/src/operations.test.ts | Adds assertions verifying DLL sidecars are copied for Windows packaging. |
| .github/workflows/turborepo-release.yml | Uploads *.dll from the Windows build output along with turbo* artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
87
to
91
| assert.equal(mockGenerateNativePackage.mock.calls.length, 1); | ||
| assert.equal(mockMkdir.mock.calls.length, 1); | ||
| assert.equal(mockCopyFile.mock.calls.length, 1); | ||
| assert.equal(mockCopyFile.mock.calls.length, 2); | ||
| assert.equal(mockChmod.mock.calls.length, 1); | ||
| assert.equal(mockChmod.mock.calls[0].arguments[1], 0o111); |
1 task
1 task
Contributor
|
Closed for slop. |
Contributor
Author
I appreciate you fixing the issue. I apologize that this solution wasn't up to par. I will work harder next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Windows release packaging can publish @turbo/windows-* without runtime DLL sidecars required by turbo.exe. The Rust artifact upload only included turbo*, and the native npm packer only copied turbo.exe. If the binary imports a sidecar such as ghostty-vt.dll, the installed package fails before startup with a missing shared library error.
Solution:
Upload DLL sidecars from the Windows build output with the release artifact, then copy DLLs into bin next to turbo.exe when building the native npm package. The copy filter is case-insensitive so mixed-case Windows DLL filenames are included.
Validation:
node --import tsx --test src/operations.test.ts
pnpm --filter @turbo/releaser check-types
oxfmt --check .github/workflows/turborepo-release.yml packages/turbo-releaser/src/operations.ts packages/turbo-releaser/src/operations.test.ts
git diff --check
pre-push: lint-staged, format, check:toml